Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1439)

Issue 4525002: make_dev_ssd: fix --remove_rootfs_verification (Closed)

Created:
10 years, 1 month ago by Hung-Te
Modified:
9 years, 7 months ago
Reviewers:
gauravsh, Will Drewry
CC:
chromium-os-reviews_chromium.org, Randall Spangler, gauravsh, Luigi Semenzato, Bill Richardson
Visibility:
Public.

Description

make_dev_ssd: fix --remove_rootfs_verification The remove_rootfs_verification was corrupted by several issues: 1. enable_rw_mount (ext2 RO bit hack) should be performed on every rootfs and only after we successfully resigned the kernel. 2. for latest images, we must first resign again before changing boot parameter, otherwise verification would fail. Both fixed and verified. BUG=chromium-os:8629 TEST=(1)built a ToT image, install by USB boot, then ./make_dev_ssd --remove_rootfs_verification; then reboot. rootdev shows /dev/sda3 and is writable. (2)install by factory setup and then wipe so that root = sda5 ./make_dev_ssd --remove_rootfs_verification; then reboot. rootdev shows /dev/sda5 and is writable. Change-Id: I27d92964f3fbe160a207069a39516a879de64245 Committed: http://chrome-svn/viewvc/chromeos?view=rev&revision=b5c991b

Patch Set 1 #

Patch Set 2 : fix indent #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+55 lines, -30 lines) Patch
M scripts/image_signing/make_dev_ssd.sh View 1 7 chunks +55 lines, -30 lines 2 comments Download

Messages

Total messages: 6 (0 generated)
Hung-Te
10 years, 1 month ago (2010-11-05 07:46:09 UTC) #1
Hung-Te
gaurav: please review if the key resigning and boot param changing part wad: please review ...
10 years, 1 month ago (2010-11-05 07:47:18 UTC) #2
gauravsh
lgtm for the signing and boot param change part http://codereview.chromium.org/4525002/diff/4001/5001 File scripts/image_signing/make_dev_ssd.sh (right): http://codereview.chromium.org/4525002/diff/4001/5001#newcode70 scripts/image_signing/make_dev_ssd.sh:70: ...
10 years, 1 month ago (2010-11-05 20:20:01 UTC) #3
Hung-Te
http://codereview.chromium.org/4525002/diff/4001/5001 File scripts/image_signing/make_dev_ssd.sh (right): http://codereview.chromium.org/4525002/diff/4001/5001#newcode70 scripts/image_signing/make_dev_ssd.sh:70: echo "$*" | grep -q 'root=/dev/dm-0' Images built with ...
10 years, 1 month ago (2010-11-06 07:40:55 UTC) #4
Will Drewry
LGTM Thanks!!
10 years, 1 month ago (2010-11-08 03:00:45 UTC) #5
Will Drewry
10 years, 1 month ago (2010-11-08 03:00:53 UTC) #6
LGTM


Thanks!!

Powered by Google App Engine
This is Rietveld 408576698