net: add Snap Start tests

net: add Snap Start tests

These tests are Linux only for now. Adding Mac support should be pretty
easy. However, Windows will be tough to do without making the tests
flakey. Given the huge amounts of pain caused by testserver.py and
ephemeral ports I'd rather get the tests working well on a couple of
platforms (since the Snap Start code is all platform-generic anyway),
then add more flakiness.

BUG=none
TEST=snap_start_unittests

[Mike Belshe, 2010-11-08 16:41:10]

lgtm

http://codereview.chromium.org/4524003/diff/3001/4003
File net/socket/ssl_client_socket_snapstart_unittest.cc (right):

http://codereview.chromium.org/4524003/diff/3001/4003#newcode5
net/socket/ssl_client_socket_snapstart_unittest.cc:5: #include
"build/build_config.h"
q: is this intentional?

http://codereview.chromium.org/4524003/diff/3001/4003#newcode257
net/socket/ssl_client_socket_snapstart_unittest.cc:257: // merge it's
certificate validation with the optimistic validation from
nit: /merge/merged

http://codereview.chromium.org/4524003/diff/3001/4004
File net/test/openssl_helper.cc (right):

http://codereview.chromium.org/4524003/diff/3001/4004#newcode7
net/test/openssl_helper.cc:7: #include <sys/types.h>
nit:  This is clearly going to be linux/mac only...

[Paweł Hajdan Jr., 2010-11-08 16:55:32]

Drive-by with test comments. Please fix them before committing.

http://codereview.chromium.org/4524003/diff/3001/4003
File net/socket/ssl_client_socket_snapstart_unittest.cc (right):

http://codereview.chromium.org/4524003/diff/3001/4003#newcode55
net/socket/ssl_client_socket_snapstart_unittest.cc:55: NOTREACHED();
Please read
http://www.chromium.org/developers/coding-style#TOC-CHECK-vs-DCHECK-and-NOTRE...

We avoid crashing the entire test binary. Moreover, this "assertion" will only
fire in debug mode.

http://codereview.chromium.org/4524003/diff/3001/4003#newcode99
net/socket/ssl_client_socket_snapstart_unittest.cc:99: LOG(FATAL) << "Failed to
get DIR_EXE";
Same here, and all other similar places.

http://codereview.chromium.org/4524003/diff/3001/4003#newcode144
net/socket/ssl_client_socket_snapstart_unittest.cc:144: CHECK(r) << "failed to
read " << path.value();
CHECK is bad too.

http://codereview.chromium.org/4524003/diff/3001/4004
File net/test/openssl_helper.cc (right):

http://codereview.chromium.org/4524003/diff/3001/4004#newcode190
net/test/openssl_helper.cc:190: if (ret != 1) {
nit: Simpler:

if (ret == 1)
  break;
...