Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1220)

Unified Diff: chrome/browser/cocoa/page_info_window_mac.mm

Issue 452042: Define X509Certificate::intermediate_ca_certs_ as a std::vector of... (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/
Patch Set: Update retain the result comment. Sync to ToT. Created 11 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | net/base/x509_certificate.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/cocoa/page_info_window_mac.mm
===================================================================
--- chrome/browser/cocoa/page_info_window_mac.mm (revision 34171)
+++ chrome/browser/cocoa/page_info_window_mac.mm (working copy)
@@ -76,13 +76,12 @@
}
CFArrayAppendValue(certificates, cert_mac);
- CFArrayRef ca_certs = cert->GetIntermediateCertificates();
- if (ca_certs) {
- // Server certificate must be first in the array; subsequent certificates
- // in the chain can be in any order.
- CFArrayAppendArray(certificates, ca_certs,
- CFRangeMake(0, CFArrayGetCount(ca_certs)));
- }
+ // Server certificate must be first in the array; subsequent certificates
+ // in the chain can be in any order.
+ const std::vector<SecCertificateRef>& ca_certs =
+ cert->GetIntermediateCertificates();
+ for (size_t i = 0; i < ca_certs.size(); ++i)
+ CFArrayAppendValue(certificates, ca_certs[i]);
[[SFCertificatePanel sharedCertificatePanel]
beginSheetForWindow:[controller_ window]
« no previous file with comments | « no previous file | net/base/x509_certificate.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698