Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(335)

Unified Diff: net/base/x509_certificate_mac.cc

Issue 452042: Define X509Certificate::intermediate_ca_certs_ as a std::vector of... (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/
Patch Set: Update retain the result comment. Sync to ToT. Created 11 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « net/base/x509_certificate.cc ('k') | net/socket/ssl_client_socket_mac.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: net/base/x509_certificate_mac.cc
===================================================================
--- net/base/x509_certificate_mac.cc (revision 34171)
+++ net/base/x509_certificate_mac.cc (working copy)
@@ -454,14 +454,8 @@
return ERR_OUT_OF_MEMORY;
scoped_cftyperef<CFArrayRef> scoped_cert_array(cert_array);
CFArrayAppendValue(cert_array, cert_handle_);
- if (intermediate_ca_certs_) {
- CFIndex intermediate_count = CFArrayGetCount(intermediate_ca_certs_);
- for (CFIndex i = 0; i < intermediate_count; ++i) {
- SecCertificateRef intermediate_cert = static_cast<SecCertificateRef>(
- const_cast<void*>(CFArrayGetValueAtIndex(intermediate_ca_certs_, i)));
- CFArrayAppendValue(cert_array, intermediate_cert);
- }
- }
+ for (size_t i = 0; i < intermediate_ca_certs_.size(); ++i)
+ CFArrayAppendValue(cert_array, intermediate_ca_certs_[i]);
SecTrustRef trust_ref = NULL;
status = SecTrustCreateWithCertificates(cert_array, ssl_policy, &trust_ref);
@@ -655,18 +649,6 @@
return false;
}
-void X509Certificate::AddIntermediateCertificate(SecCertificateRef cert) {
- if (cert) {
- if (!intermediate_ca_certs_) {
- intermediate_ca_certs_ = CFArrayCreateMutable(kCFAllocatorDefault, 0,
- &kCFTypeArrayCallBacks);
- }
- if (intermediate_ca_certs_) {
- CFArrayAppendValue(intermediate_ca_certs_, cert);
- }
- }
-}
-
// static
X509Certificate::OSCertHandle X509Certificate::CreateOSCertHandleFromBytes(
const char* data, int length) {
« no previous file with comments | « net/base/x509_certificate.cc ('k') | net/socket/ssl_client_socket_mac.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698