Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(311)

Issue 4520001: AU: Add test-channel to the list of valid tracks. (Closed)

Created:
10 years, 1 month ago by petkov
Modified:
9 years, 7 months ago
Reviewers:
satorux1, adlr
CC:
chromium-os-reviews_chromium.org, petkov, adlr, Sumit, rtc
Visibility:
Public.

Description

AU: Add test-channel to the list of valid tracks. BUG=8384 TEST=unit tests Change-Id: Ifbf6918c70301de4437f6c161aa6d761e3ad47ba Committed: http://chrome-svn/viewvc/chromeos?view=rev&revision=3f375c7

Patch Set 1 #

Patch Set 2 : rename test-channel to canary-channel #

Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -2 lines) Patch
M omaha_request_params.cc View 1 1 chunk +14 lines, -2 lines 0 comments Download
M omaha_request_params_unittest.cc View 1 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
petkov
10 years, 1 month ago (2010-11-04 22:25:30 UTC) #1
adlr
LGTM!
10 years, 1 month ago (2010-11-04 23:31:36 UTC) #2
satorux1
How do we call this externally? If we call "Canary channel", then "canary-channel" would be ...
10 years, 1 month ago (2010-11-05 01:47:23 UTC) #3
adlr
I'm fine w/ either. canary is nice for consistency w/ chrome, but I don't really ...
10 years, 1 month ago (2010-11-05 02:00:23 UTC) #4
satorux1
I'm adding this to the channel switching UI, and I thought "Test" might not sound ...
10 years, 1 month ago (2010-11-05 02:09:49 UTC) #5
petkov
10 years, 1 month ago (2010-11-05 16:42:50 UTC) #6
Renamed to "canary-channel", retested and pushed.

Powered by Google App Engine
This is Rietveld 408576698