Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(117)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 4517004: Move Windows-specific Event Tracing for Windows implementation to base/win. ... (Closed)

Created:
10 years, 1 month ago by Sigurður Ásgeirsson
Modified:
9 years, 7 months ago
Reviewers:
M-A Ruel
CC:
chromium-reviews, Paweł Hajdan Jr., brettw-cc_chromium.org
Visibility:
Public.

Description

Move Windows-specific Event Tracing for Windows implementation to base/win. fix users of same. BUG=none TEST=unittests Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=65310

Patch Set 1 #

Patch Set 2 : Fixed another ETW user in Chrome Frame #

Unified diffs Side-by-side diffs Delta from patch set Stats (+94 lines, -1445 lines) Patch
M base/base.gyp View 3 chunks +3 lines, -6 lines 0 comments Download
M base/base.gypi View 2 chunks +5 lines, -5 lines 0 comments Download
M base/debug/trace_event_win.h View 3 chunks +5 lines, -5 lines 0 comments Download
M base/debug/trace_event_win.cc View 1 chunk +3 lines, -0 lines 0 comments Download
M base/debug/trace_event_win_unittest.cc View 2 chunks +7 lines, -2 lines 0 comments Download
D base/event_trace_consumer_win.h View 1 chunk +0 lines, -144 lines 0 comments Download
D base/event_trace_consumer_win_unittest.cc View 1 chunk +0 lines, -340 lines 0 comments Download
D base/event_trace_controller_win.h View 1 chunk +0 lines, -144 lines 0 comments Download
D base/event_trace_controller_win.cc View 1 chunk +0 lines, -167 lines 0 comments Download
D base/event_trace_controller_win_unittest.cc View 1 chunk +0 lines, -204 lines 0 comments Download
D base/event_trace_provider_win.h View 1 chunk +0 lines, -168 lines 0 comments Download
D base/event_trace_provider_win.cc View 1 chunk +0 lines, -128 lines 0 comments Download
D base/event_trace_provider_win_unittest.cc View 1 chunk +0 lines, -107 lines 0 comments Download
M base/logging_win.h View 2 chunks +2 lines, -2 lines 0 comments Download
M base/logging_win.cc View 1 chunk +3 lines, -0 lines 0 comments Download
A + base/win/event_trace_consumer.h View 3 chunks +9 lines, -3 lines 0 comments Download
A + base/win/event_trace_consumer_unittest.cc View 2 chunks +9 lines, -3 lines 0 comments Download
A + base/win/event_trace_controller.h View 3 chunks +9 lines, -3 lines 0 comments Download
A + base/win/event_trace_controller.cc View 2 chunks +7 lines, -1 line 0 comments Download
A + base/win/event_trace_controller_unittest.cc View 2 chunks +6 lines, -2 lines 0 comments Download
A + base/win/event_trace_provider.h View 3 chunks +9 lines, -3 lines 0 comments Download
A + base/win/event_trace_provider.cc View 2 chunks +7 lines, -1 line 0 comments Download
A + base/win/event_trace_provider_unittest.cc View 1 chunk +4 lines, -1 line 0 comments Download
M chrome_frame/test/perf/chrome_frame_perftest.cc View 5 chunks +6 lines, -6 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Sigurður Ásgeirsson
10 years, 1 month ago (2010-11-05 20:25:27 UTC) #1
M-A Ruel
lgtm
10 years, 1 month ago (2010-11-05 20:32:21 UTC) #2
Sigurður Ásgeirsson
10 years, 1 month ago (2010-11-06 13:07:11 UTC) #3 
Added chrome_frame_perftest to the CL. Please take another quick look.

Powered by Google App Engine
This is Rietveld 408576698