Issue 4517003: Special case global and non-global code paths in regexp.test.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 4517003: Special case global and non-global code paths in regexp.test. (Closed)

Created:
10 years, 1 month ago by sandholm

Modified:
9 years, 7 months ago

Reviewers:
Lasse Reichstein

CC:
v8-dev

Base URL:
http://v8.googlecode.com/svn/branches/bleeding_edge/

Visibility:
Public.

Description

Special case global and non-global code paths in regexp.test. Committed: http://code.google.com/p/v8/source/detail?r=5810

Patch Set 1 #

Total comments: 1

Created: 10 years, 1 month ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+34 lines, -37 lines)			Patch
	M	src/regexp.js	View		2 chunks	+34 lines, -37 lines	1 comment	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Lasse Reichstein

10 years, 1 month ago (2010-11-05 14:01:29 UTC) #2

LGTM

http://codereview.chromium.org/4517003/diff/1/2
File src/regexp.js (right):

http://codereview.chromium.org/4517003/diff/1/2#newcode265
src/regexp.js:265: %_StringCharCodeAt(this.source, 2) != 63) {  // '?'
Why not do this for global regexps too?

Expand Messages | Collapse Messages