Reduce the size of the stateful update by only copying dirs and some clean up.

Reduce the size of the stateful update by only copying dirs and some clean up.

Besides speeding up this step this also reduces the size necessray for a
stateful update since we only need the size of dev_image + var as scracth
space rather than a whole partition size (1 or 2GB before ... now ~ 128MB)

Change-Id: Ic566f89d44a29955707513b5cb2e4b7bf781fed6

BUG=8885
TEST=Ran it on a vm.

Committed: http://chrome-svn/viewvc/chromeos?view=rev&revision=05491b1

[petkov, 2010-11-07 04:54:11]

Do you really need the copy?

http://codereview.chromium.org/4516004/diff/1/2
File autoupdate.py (right):

http://codereview.chromium.org/4516004/diff/1/2#newcode255
autoupdate.py:255: '--rootfs_mountpt=%s' % rootfs_dir,
Maybe add a comment that you don't really need to mount rootfs but
mount_gpt_image.sh forces you to.

http://codereview.chromium.org/4516004/diff/1/2#newcode259
autoupdate.py:259: subprocess.check_call(['sudo',
Do you really need to copy? Can't you do something like:

sudo tar czf --directory $stateful_dir $from_dir/stateful.tgz ./dev_image ./var

http://codereview.chromium.org/4516004/diff/1/2#newcode265
autoupdate.py:265: #shutil.copytree(os.path.join(stateful_dir, 'dev_image'),
remove comment. and below. and maybe add a comment why you're using cp rather
than copytree.

http://codereview.chromium.org/4516004/diff/1/3
File stateful_update (right):

http://codereview.chromium.org/4516004/diff/1/3#newcode53
stateful_update:53: STATEFUL_UPDATE_URL="$BASE_UPDATE_URL/stateful.tar.gz"
I'd use .tgz but .tar.gz is also OK.

http://codereview.chromium.org/4516004/diff/1/3#newcode66
stateful_update:66: if [ -d "$WORK_DIR/var" ] && \
Doesn't this fit on one line?

[sosa, 2010-11-08 22:26:05]

PTAL

http://codereview.chromium.org/4516004/diff/1/2
File autoupdate.py (right):

http://codereview.chromium.org/4516004/diff/1/2#newcode255
autoupdate.py:255: '--rootfs_mountpt=%s' % rootfs_dir,
On 2010/11/07 04:54:11, petkov wrote:
> Maybe add a comment that you don't really need to mount rootfs but
> mount_gpt_image.sh forces you to.
> 

Done.

http://codereview.chromium.org/4516004/diff/1/2#newcode259
autoupdate.py:259: subprocess.check_call(['sudo',
On 2010/11/07 04:54:11, petkov wrote:
> Do you really need to copy? Can't you do something like:
> 
> sudo tar czf --directory $stateful_dir $from_dir/stateful.tgz ./dev_image
./var
> 

Done.

http://codereview.chromium.org/4516004/diff/1/2#newcode265
autoupdate.py:265: #shutil.copytree(os.path.join(stateful_dir, 'dev_image'),
On 2010/11/07 04:54:11, petkov wrote:
> remove comment. and below. and maybe add a comment why you're using cp rather
> than copytree.
> 
> 
> 

Done.

http://codereview.chromium.org/4516004/diff/1/2#newcode296
autoupdate.py:296: subprocess.call(['sudo',
Changed these to be more pythonic

http://codereview.chromium.org/4516004/diff/1/3
File stateful_update (right):

http://codereview.chromium.org/4516004/diff/1/3#newcode53
stateful_update:53: STATEFUL_UPDATE_URL="$BASE_UPDATE_URL/stateful.tar.gz"
On 2010/11/07 04:54:11, petkov wrote:
> I'd use .tgz but .tar.gz is also OK.
> 

Done.

http://codereview.chromium.org/4516004/diff/1/3#newcode66
stateful_update:66: if [ -d "$WORK_DIR/var" ] && \
I like long files ... it gives me more points in who writes the longest code
game.  Kidding :)

Done.

On 2010/11/07 04:54:11, petkov wrote:
> Doesn't this fit on one line?
>

[petkov, 2010-11-08 22:49:12]

LGTM