Fix pkg-config-wrapper to work with chromiumos chroots

Fix pkg-config-wrapper to work with chromiumos chroots

Some pkg-config packages in chromium os (e.g. gtk) end up hard-coding libdir to be absolute (rather than relative to prefix), so it breaks builds from outside the chroot.
This works around it.

BUG=none
TEST=build with sysroot=/path/to/chromiumos/chroot/build/x86-generic

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=65580

[piman, 2010-11-07 18:49:34]

ping ?

Should I find another reviewer ?

Antoine

On Thu, Nov 4, 2010 at 7:09 PM, <piman@chromium.org> wrote:

> Reviewers: Evan Martin,
>
> Description:
> Fix pkg-config-wrapper to work with chromiumos chroots
>
> Some pkg-config packages in chromium os (e.g. gtk) end up hard-coding
> libdir to
> be absolute (rather than relative to prefix), so it breaks builds from
> outside
> the chroot.
> This works around it.
>
> BUG=none
> TEST=build with sysroot=/path/to/chromiumos/chroot/build/x86-generic
>
> Please review this at http://codereview.chromium.org/4516002/show
>
> SVN Base: svn://svn.chromium.org/chrome/trunk/src
>
> Affected files:
>  M build/linux/pkg-config-wrapper
>
>
> Index: build/linux/pkg-config-wrapper
> diff --git a/build/linux/pkg-config-wrapper
> b/build/linux/pkg-config-wrapper
> index
>
fa76c2ea523bb7f41e92b95d797eba1798fee442..6ce9e2aa7e8f398acd014719540531253e91ac00
> 100755
> --- a/build/linux/pkg-config-wrapper
> +++ b/build/linux/pkg-config-wrapper
> @@ -11,4 +11,4 @@ rewrite=`dirname $0`/rewrite_dirs.py
>
>  shift
>  config_path=$root/usr/lib/pkgconfig:$root/usr/share/pkgconfig
> -PKG_CONFIG_PATH=$config_path pkg-config --define-variable=prefix=/usr "$@"
> | $rewrite $root
> +PKG_CONFIG_PATH=$config_path pkg-config --define-variable=prefix=/usr
> --define-variable=libdir=/usr/lib "$@" | $rewrite $root
>
>
>

[Evan Martin, 2010-11-09 06:34:57]

LGTM