Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(475)

Issue 45064: Change InspectorResource definition from struct to class (Closed)

Created:
11 years, 9 months ago by yurys
Modified:
9 years, 7 months ago
Reviewers:
dglazkov, pfeldman
CC:
chromium-reviews_googlegroups.com
Visibility:
Public.

Description

Since revision 41449 InspectorResource is defined as class. Before that it had been declared as struct. See http://trac.webkit.org/changeset/41449 In our forked version of InspectorConroller it's still defined as struct which conflicts with the rest of WebCore classes and may lead to compilation errors like below if CachedResource.h and InspectorController.h are imported in a single file: c:\chrome\src\third_party\webkit\webcore\loader\CachedResource.h(42) : error C2220: warning treated as error - no 'object' file generated c:\chrome\src\third_party\webkit\webcore\loader\CachedResource.h(42) : warning C4099: 'WebCore::InspectorResource' : type name first seen using 'struct' now seen using 'class' C:\chrome\src\third_party\WebKit\WebCore\inspector\InspectorController.h(80) : see declaration of 'WebCore::InspectorResource' c:\chrome\src\third_party\webkit\webcore\loader\CachedResource.h(51) : warning C4099: 'WebCore::InspectorResource' : type name first seen using 'struct' now seen using 'class' C:\chrome\src\third_party\WebKit\WebCore\inspector\InspectorController.h(80) : see declaration of 'WebCore::InspectorResource' Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=12556

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -2 lines) Patch
M third_party/WebKit/WebCore/inspector/InspectorController.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/WebCore/inspector/InspectorController.cpp View 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 3 (0 generated)
yurys
11 years, 9 months ago (2009-03-26 15:39:50 UTC) #1
pfeldman
LGTM
11 years, 9 months ago (2009-03-26 15:49:56 UTC) #2
dglazkov
11 years, 9 months ago (2009-03-26 16:10:18 UTC) #3
LGTM.

Powered by Google App Engine
This is Rietveld 408576698