Issue 45061: Disk cache: Add a unit test that instantiates three caches...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 45061: Disk cache: Add a unit test that instantiates three caches... (Closed)

Created:
11 years, 9 months ago by rvargas (doing something else)

Modified:
9 years, 6 months ago

Reviewers:
Alpha Left Google

CC:
chromium-reviews_googlegroups.com

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

Description

Disk cache: Add a unit test that instantiates three caches at the same time (for media files). Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=12561

Patch Set 1 #

Total comments: 1

Created: 11 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+50 lines, -7 lines)			Patch
M	net/disk_cache/backend_unittest.cc	View	1 chunk	+28 lines, -0 lines	0 comments	Download
M	net/disk_cache/disk_cache_test_util.h	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	net/disk_cache/disk_cache_test_util.cc	View	3 chunks	+21 lines, -7 lines	1 comment	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Alpha Left Google

11 years, 9 months ago (2009-03-26 00:08:12 UTC) #2

LGTM with a little nit.

http://codereview.chromium.org/45061/diff/1/2
File net/disk_cache/disk_cache_test_util.cc (right):

http://codereview.chromium.org/45061/diff/1/2#newcode19
Line 19: std::wstring BuildCachePath(const std::wstring name) {
Can we name this function GetCachePath(const std::wstring name)? We can also get
rid of namespace and put it next to GetCachePath.

Expand Messages | Collapse Messages