Issue 4506002: Make sure the app section opens whenever a new apps is

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 4506002: Make sure the app section opens whenever a new apps is (Closed)

Created:
10 years, 1 month ago by Aaron Boodman

Modified:
9 years, 6 months ago

Reviewers:
Erik does not do reviews

CC:
chromium-reviews, arv (Not doing code reviews), ben+cc_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

Description

Make sure the app section opens whenever a new apps is installed, even if the installation is through default installation. BUG=61973 TEST=Have an app installed, then close apps section, then install a new app. Apps section should re-open. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=65213

Patch Set 1 #

Patch Set 2 : comment cleanup #

Total comments: 2

Created: 10 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+36 lines, -17 lines)			Patch
M	chrome/browser/dom_ui/shown_sections_handler.h	View	1	3 chunks	+6 lines, -1 line	0 comments	Download
M	chrome/browser/dom_ui/shown_sections_handler.cc	View		3 chunks	+30 lines, -9 lines	2 comments	Download
M	chrome/browser/resources/ntp/apps.js	View		1 chunk	+0 lines, -7 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Erik does not do reviews

LGTM http://codereview.chromium.org/4506002/diff/2001/3001 File chrome/browser/dom_ui/shown_sections_handler.cc (right): http://codereview.chromium.org/4506002/diff/2001/3001#newcode83 chrome/browser/dom_ui/shown_sections_handler.cc:83: // Hide any open sections. Shouldn't this be ...

10 years, 1 month ago (2010-11-04 23:40:38 UTC) #2

Aaron Boodman

10 years, 1 month ago (2010-11-05 00:08:34 UTC) #3

http://codereview.chromium.org/4506002/diff/2001/3001
File chrome/browser/dom_ui/shown_sections_handler.cc (right):

http://codereview.chromium.org/4506002/diff/2001/3001#newcode83
chrome/browser/dom_ui/shown_sections_handler.cc:83: // Hide any open sections.
On 2010/11/04 23:40:39, Erik Kay wrote:
> Shouldn't this be "minimize" rather than "hide"?  Or maybe I'm confused by the
> use of these two words here.

The nomenclature in NTP is all messed up. We unfortunately use "minimize" for
"hit the x in the right top corner", which causes lots of awkwardness.

Expand Messages | Collapse Messages