Issue 45054: Block Oriya locale on Windows XP....

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 45054: Block Oriya locale on Windows XP.... (Closed)

Created:
11 years, 9 months ago by jungshik at Google

Modified:
9 years, 7 months ago

Reviewers:
tony

CC:
chromium-reviews_googlegroups.com

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

Description

Block Oriya locale on Windows XP. Add IsLocaleSupportedByOS to l10n_util_{win,posix}.cc. Posix version always returns true. Windows blocks Oriya on Windows XP. BUG=7325 TEST=1. L10n*.GetAppLocale 2. On Win XP, Oriya should not be shown in the UI language switch menu while it should be shown elsewhere. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=12557

Patch Set 1 #

Patch Set 2 : '' #

Patch Set 3 : '' #

Patch Set 4 : '' #

Patch Set 5 : '' #

Patch Set 6 : '' #

Created: 11 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+54 lines, -0 lines)			Patch
M	chrome/chrome.gyp	View		1 chunk	+1 line, -0 lines	0 comments	Download
M	chrome/common/common.scons	View		2 chunks	+2 lines, -0 lines	0 comments	Download
M	chrome/common/l10n_util.h	View		1 chunk	+5 lines, -0 lines	0 comments	Download
M	chrome/common/l10n_util.cc	View	1 2 3	2 chunks	+5 lines, -0 lines	0 comments	Download
A	chrome/common/l10n_util_posix.cc	View		1 chunk	+14 lines, -0 lines	0 comments	Download
M	chrome/common/l10n_util_unittest.cc	View		3 chunks	+19 lines, -0 lines	0 comments	Download
M	chrome/common/l10n_util_win.cc	View		2 chunks	+8 lines, -0 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

tony

Instead of adding #if's, can you put this in l10n_util.h and l10n_util_win.cc. You can add ...

11 years, 9 months ago (2009-03-25 20:36:22 UTC) #2

jungshik at Google

On 2009/03/25 20:36:22, tony wrote: > Instead of adding #if's, can you put this in ...

11 years, 9 months ago (2009-03-25 22:32:56 UTC) #3

tony

11 years, 9 months ago (2009-03-25 23:04:20 UTC) #4

The code looks good, but I think you need to add l10n_util_posix.cc to the
chrome.gyp file and the common.scons file.  Once you do that and it passes on
the try bots, LGTM!

On 2009/03/25 22:32:56, Jungshik Shin wrote:
> On 2009/03/25 20:36:22, tony wrote:
> > Instead of adding #if's, can you put this in l10n_util.h and
l10n_util_win.cc.
> 
> > You can add a l10n_util_posix that has a stub implementation for linux/mac.
> 
> Ok. I've done that. Pls, take another look.

Expand Messages | Collapse Messages