Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(8609)

Unified Diff: chrome/test/ui/ui_test.cc

Issue 45053: When running ui_tests, need to tell valgrind to also trace child processes. (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/
Patch Set: '' Created 11 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | tools/valgrind/chrome_tests.py » ('j') | tools/valgrind/valgrind_test.py » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/test/ui/ui_test.cc
===================================================================
--- chrome/test/ui/ui_test.cc (revision 12555)
+++ chrome/test/ui/ui_test.cc (working copy)
@@ -354,6 +354,18 @@
!show_window_,
&process_);
#elif defined(OS_POSIX)
+ // Sometimes one needs to run the browser under a special environment
+ // (e.g. valgrind) without also running the test harness (e.g. python)
+ // under the special environment. Provide a way to wrap the browser
+ // commandline with a special prefix to invoke the special environment.
+ const char* browser_wrapper = getenv("BROWSER_WRAPPER");
+ if (browser_wrapper) {
+ CommandLine wrapped_command(ASCIIToWide(browser_wrapper));
+ wrapped_command.AppendArguments(command_line, true);
+ command_line = wrapped_command;
+ LOG(INFO) << "BROWSER_WRAPPER was set, prefixing command_line with " << browser_wrapper;
Dean McNamee 2009/03/27 11:34:55 80 cols
+ }
+
bool started = base::LaunchApp(command_line.argv(),
server_->fds_to_map(),
false, // Don't wait.
« no previous file with comments | « no previous file | tools/valgrind/chrome_tests.py » ('j') | tools/valgrind/valgrind_test.py » ('J')

Powered by Google App Engine
This is Rietveld 408576698