Issue 45053: When running ui_tests, need to tell valgrind to also trace child processes.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 45053: When running ui_tests, need to tell valgrind to also trace child processes. (Closed)

Created:
11 years, 9 months ago by dank

Modified:
9 years, 7 months ago

Reviewers:
Dean McNamee, Elliot Glaysher

CC:
chromium-reviews_googlegroups.com, Nirnimesh

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

Description

When running ui_tests, need to tell valgrind to also trace child processes. Also need to avoid valgrinding python. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=12572

Patch Set 4 : '' #

Total comments: 2

Created: 11 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+54 lines, -3 lines)			Patch
M	chrome/test/ui/ui_test.cc	View	2	1 chunk	+12 lines, -0 lines	1 comment	Download
M	tools/valgrind/chrome_tests.py	View	1 2	3 chunks	+11 lines, -2 lines	0 comments	Download
M	tools/valgrind/valgrind_test.py	View	1 2 3	4 chunks	+31 lines, -1 line	1 comment	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

Elliot Glaysher

http://codereview.chromium.org/45053/diff/1001/2002 File tools/valgrind/valgrind_test.py (right): http://codereview.chromium.org/45053/diff/1001/2002#newcode214 Line 214: # TODO: put somewhere safe What does this ...

11 years, 9 months ago (2009-03-26 17:24:14 UTC) #1

Elliot Glaysher

On 2009/03/26 17:50:04, dank wrote: > Fixed. LGTM

11 years, 9 months ago (2009-03-26 18:01:35 UTC) #3

Dean McNamee

11 years, 9 months ago (2009-03-27 11:34:55 UTC) #4

http://codereview.chromium.org/45053/diff/2010/1011
File chrome/test/ui/ui_test.cc (right):

http://codereview.chromium.org/45053/diff/2010/1011#newcode366
Line 366: LOG(INFO) << "BROWSER_WRAPPER was set, prefixing command_line with "
<< browser_wrapper;
80 cols

http://codereview.chromium.org/45053/diff/2010/1010
File tools/valgrind/valgrind_test.py (right):

http://codereview.chromium.org/45053/diff/2010/1010#newcode68
Line 68: help="set BROWSER_WRAPPER rather than running valgrind directly")
80 cols

Expand Messages | Collapse Messages

Issue 45053: When running ui_tests, need to tell valgrind to also trace child processes. (Closed)

Description

Patch Set 1 #

Patch Set 2 : '' #

Patch Set 3 : '' #

Patch Set 4 : '' #

Messages