Fix pre-generate logic to work with latest and fix other bug.

Fix pre-generate logic to work with latest and fix other bug.

Change-Id: I19d1ff21833c36bad8e59514bd64af55d59633df

BUG=8732
TEST=./start_devserver with -p --board=x86-mario --client_prefix=C

Committed: http://chrome-svn/viewvc/chromeos?view=rev&revision=e67b78f

[sosa, 2010-11-04 21:25:51]

Re-factored a bit to make it clearer when the pre-generate fails (removes issue
where you see update fail, stateful succeed .. so overall update fails)

[petkov, 2010-11-04 21:33:39]

LGTM w/ a couple of suggestions (fix the indent though).

http://codereview.chromium.org/4504001/diff/2001/3001
File autoupdate.py (right):

http://codereview.chromium.org/4504001/diff/2001/3001#newcode305
autoupdate.py:305: static_image_dir)
fix indent

http://codereview.chromium.org/4504001/diff/2001/3001#newcode306
autoupdate.py:306: else:
You could remove the else: here

http://codereview.chromium.org/4504001/diff/2001/3001#newcode486
autoupdate.py:486: else:
you could remove the else: here

[dgarrett, 2010-11-04 21:35:10]

Why not incorporate Darin's fix for GenerateUpdatePayloadForNonFactory, which
fails to return a result for the forced_image case?

[sosa, 2010-11-04 22:25:27]

Committing with darin's fix

http://codereview.chromium.org/4504001/diff/2001/3001
File autoupdate.py (right):

http://codereview.chromium.org/4504001/diff/2001/3001#newcode305
autoupdate.py:305: static_image_dir)
On 2010/11/04 21:33:39, petkov wrote:
> fix indent
> 

Done.

http://codereview.chromium.org/4504001/diff/2001/3001#newcode306
autoupdate.py:306: else:
On 2010/11/04 21:33:39, petkov wrote:
> You could remove the else: here
> 

Done.

http://codereview.chromium.org/4504001/diff/2001/3001#newcode486
autoupdate.py:486: else:
On 2010/11/04 21:33:39, petkov wrote:
> you could remove the else: here
> 

Done.