src/prettyprinter.cc - Issue 45010: Remove all uses of StringShape variables, since that has proven...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/prettyprinter.cc

Issue 45010: Remove all uses of StringShape variables, since that has proven... (Closed) Base URL: http://v8.googlecode.com/svn/branches/bleeding_edge/

Patch Set: Created 11 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: src/prettyprinter.cc

===================================================================

--- src/prettyprinter.cc (revision 1519)

+++ src/prettyprinter.cc (working copy)

@@ -517,10 +517,9 @@

Object* object = *value;

if (object->IsString()) {

String* string = String::cast(object);

- StringShape shape(string);

if (quote) Print("\"");

- for (int i = 0; i < string->length(shape); i++) {

- Print("%c", string->Get(shape, i));

+ for (int i = 0; i < string->length(); i++) {

+ Print("%c", string->Get(i));

}

if (quote) Print("\"");

} else if (object == Heap::null_value()) {

« no previous file with comments | « src/parser.cc ('k') | src/regexp-macro-assembler-ia32.cc » ('j') | no next file with comments »