Remove the last context dependent reference from the Script object...

Remove the last context dependent reference from the Script object

For scripts originating from a call to eval the Script object used to hold a reference to the function from where the eval was called together with the code offset within that function of the eval call. This is used by the stack trace and is part of the debugger protocol. In order to avoid storing the function the script, the position within the script and the name of the function calling eval is stored instead. This avoids holding context dependent objects in the script object.

The calculation of the position of the eval in the script holding the eval is now done when the eval script is compiled as it is not possible to postpone this unless a reference is kept to the generated code for the function calling eval.

BUG=http://code.google.com/p/v8/issues/detail?id=528
TEST=cctest/test-api/Regress528

Committed: http://code.google.com/p/v8/source/detail?r=3393

[Mads Ager (chromium), 2009-12-01 13:57:21]

LGTM

[Mads Ager (chromium), 2009-12-01 14:02:26]

Come to think of it I would prefer to point to the shared function info for the
calling function.  That will allow lazy computation of the position when needed
and save space in scripts.

[Søren Thygesen Gjesse, 2009-12-01 14:38:09]

On 2009/12/01 14:02:26, Mads Ager wrote:
> Come to think of it I would prefer to point to the shared function info for
the
> calling function.  That will allow lazy computation of the position when
needed
> and save space in scripts.

Changed to store shared function info and instructions offset. This saves one
word in the Script object and makes it possible to delay the calculation of the
source position until it is requested.

[Mads Ager (chromium), 2009-12-01 14:43:12]

LGTM with one comment.

http://codereview.chromium.org/450034/diff/2006/2010
File src/compiler.cc (right):

http://codereview.chromium.org/450034/diff/2006/2010#newcode182
src/compiler.cc:182: if (it.frame()->function()->IsJSFunction())
Is this conditional needed?  If it is indentation is off.