Issue 45003: Install more signal handlers so test shell cleanup after itself.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 45003: Install more signal handlers so test shell cleanup after itself. (Closed)

Created:
11 years, 9 months ago by Lei Zhang

Modified:
9 years, 7 months ago

Reviewers:
Elliot Glaysher, Evan Stade

CC:
chromium-reviews_googlegroups.com

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

Description

Install more signal handlers so test shell cleanup after itself. Found a couple more cases where we are littering files in /tmp. a) if we run test_shell and hit ctrl+c, b) if the test shell gets killed by KillAllTestShells(). Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=11412

Patch Set 1 #

Total comments: 1

Created: 11 years, 9 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+9 lines, -0 lines)			Patch
	M	webkit/tools/test_shell/test_shell_gtk.cc	View		2 chunks	+9 lines, -0 lines	1 comment	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Evan Stade

11 years, 9 months ago (2009-03-11 01:26:38 UTC) #3

http://codereview.chromium.org/45003/diff/1/2
File webkit/tools/test_shell/test_shell_gtk.cc (right):

http://codereview.chromium.org/45003/diff/1/2#newcode191
Line 191: // Install an signal handler so we clean up after ourselves.
nit: an->a

Expand Messages | Collapse Messages