Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(72)

Issue 4499006: crash-reporter: Ignore Chrome crashes, relying on Chrome breakpad (Closed)

Created:
10 years, 1 month ago by kmixter1
Modified:
9 years, 7 months ago
Reviewers:
petkov
CC:
chromium-os-reviews_chromium.org
Visibility:
Public.

Description

crash-reporter: Ignore Chrome crashes, relying on Chrome breakpad Change-Id: I08e44d2c8b6be839d18efd2fe6e8b612a61ae723 BUG=8841 TEST=bvts Committed: http://chrome-svn/viewvc/chromeos?view=rev&revision=d2f1fb4

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+34 lines, -11 lines) Patch
M user_collector.cc View 1 chunk +14 lines, -2 lines 1 comment Download
M user_collector_test.cc View 1 chunk +20 lines, -9 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
kmixter1
10 years, 1 month ago (2010-11-09 23:23:13 UTC) #1
petkov
10 years, 1 month ago (2010-11-09 23:30:12 UTC) #2
LGTM

http://codereview.chromium.org/4499006/diff/1/user_collector.cc
File user_collector.cc (right):

http://codereview.chromium.org/4499006/diff/1/user_collector.cc#newcode453
user_collector.cc:453: feedback = false;
probably doesn't matter but feedback may be false already. not sure if you care
to mark these as ignoring because it's chrome or ignoring because there's no
consent. or maybe you want a separate string.

Powered by Google App Engine
This is Rietveld 408576698