Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(441)

Issue 449051: Update test for issue 528... (Closed)

Created:
11 years ago by Søren Thygesen Gjesse
Modified:
9 years, 7 months ago
CC:
v8-dev
Visibility:
Public.

Description

Update test for issue 528 The check for the number og GC's required is now 1 or 2 instead of two to get rig of failures on ARM. Updated the test to keep the code used by the test in the compilation cache by compiling it in another context. This makes the remaining issue with the eval cache more explicit. Committed: http://code.google.com/p/v8/source/detail?r=3387

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+32 lines, -15 lines) Patch
M test/cctest/test-api.cc View 4 chunks +32 lines, -15 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
Søren Thygesen Gjesse
Still I don't know why one GC is used on ARM.
11 years ago (2009-12-01 09:29:10 UTC) #1
Mads Ager (chromium)
11 years ago (2009-12-01 09:31:03 UTC) #2
LGTM to get the buildbot green.

We should of course find the reason.  Maybe you could file a bug report to keep
track?

Powered by Google App Engine
This is Rietveld 408576698