Move some XDG code from chrome to base.

Move some XDG code from chrome to base, make DIR_USER_CACHE generic rather than Chromium specific, and clean up a few headers.

BUG=none
TEST=none

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=33565

[Lei Zhang, 2009-12-01 04:51:40]

I ran: svn mv chrome/third_party/xdg_user_dirs base/third_party, but I think gcl
got confused.

http://codereview.chromium.org/449048/diff/1/3
File base/base_paths.h (right):

http://codereview.chromium.org/449048/diff/1/3#newcode34
base/base_paths.h:34: DIR_USER_CACHE,   // $XDG_CACHE_HOME on Linux.
base::DIR_USER_CACHE is just $XDG_CACHE_HOME, whereas chrome::DIR_USER_CACHE was
$XDG_CACHE_HOME/chromium.

[Evan Martin, 2009-12-01 06:38:48]

Can you make the review description more descriptive?

http://codereview.chromium.org/449048/diff/2013/1012
File base/base_paths.h (left):

http://codereview.chromium.org/449048/diff/2013/1012#oldcode17
base/base_paths.h:17: #include "base/path_service.h"
Ah, I was confused why the other files had the add, but this is a good change!

http://codereview.chromium.org/449048/diff/2013/1012
File base/base_paths.h (right):

http://codereview.chromium.org/449048/diff/2013/1012#newcode34
base/base_paths.h:34: DIR_USER_CACHE,   // $XDG_CACHE_HOME on Linux.
Since this file is now shared by all platforms, maybe it'd be better to describe
what the value means and then maybe mention Linux as an example.

http://codereview.chromium.org/449048/diff/2013/1015
File base/base_paths_posix.cc (right):

http://codereview.chromium.org/449048/diff/2013/1015#newcode13
base/base_paths_posix.cc:13: #include "base/linux_util.h"
There's a FREEBSD define below, I wonder if it's worth trying to not break that.


Edit: nm, I see linux_util will need a bunch of work for non-Linux platforms.

http://codereview.chromium.org/449048/diff/2013/1014
File base/linux_util.cc (right):

http://codereview.chromium.org/449048/diff/2013/1014#newcode197
base/linux_util.cc:197: /* last resort */
// C++-style comments

http://codereview.chromium.org/449048/diff/2013/1014#newcode198
base/linux_util.cc:198: return FilePath("/tmp/");
I think normally we don't end paths with / ?

http://codereview.chromium.org/449048/diff/2013/1013
File base/linux_util.h (right):

http://codereview.chromium.org/449048/diff/2013/1013#newcode50
base/linux_util.h:50: // Wrapper around xdg_user_dir_lookup() from
src/base/third_party/xdg-user-dirs
Can you describe what it does?  It looks identical to the function above it (?)

http://codereview.chromium.org/449048/diff/2013/1016
File chrome/browser/profile.cc (right):

http://codereview.chromium.org/449048/diff/2013/1016#newcode615
chrome/browser/profile.cc:615: PathService::Get(base::DIR_USER_CACHE,
&base_cache_path_);
Hm, interesting, so USER_CACHE now returns the top-level cache dir but not the
Chrome-specific one?  I wonder how useful that is for other platforms...

[Lei Zhang, 2009-12-01 20:04:20]

http://codereview.chromium.org/449048/diff/2013/1012
File base/base_paths.h (left):

http://codereview.chromium.org/449048/diff/2013/1012#oldcode17
base/base_paths.h:17: #include "base/path_service.h"
On 2009/12/01 06:38:48, Evan Martin wrote:
> Ah, I was confused why the other files had the add, but this is a good change!

There's a few more files added because of this.

http://codereview.chromium.org/449048/diff/2013/1012
File base/base_paths.h (right):

http://codereview.chromium.org/449048/diff/2013/1012#newcode34
base/base_paths.h:34: DIR_USER_CACHE,   // $XDG_CACHE_HOME on Linux.
On 2009/12/01 06:38:48, Evan Martin wrote:
> Since this file is now shared by all platforms, maybe it'd be better to
describe
> what the value means and then maybe mention Linux as an example.

Done. FYI, I will merge mac's DIR_CACHE with this in a separate CL.

http://codereview.chromium.org/449048/diff/2013/1015
File base/base_paths_posix.cc (right):

http://codereview.chromium.org/449048/diff/2013/1015#newcode13
base/base_paths_posix.cc:13: #include "base/linux_util.h"
On 2009/12/01 06:38:48, Evan Martin wrote:
> There's a FREEBSD define below, I wonder if it's worth trying to not break
that.
> 
> 
> Edit: nm, I see linux_util will need a bunch of work for non-Linux platforms.

The code that digs into /proc is mostly for sandboxing. Aside from that, the
other bits should work.

http://codereview.chromium.org/449048/diff/2013/1014
File base/linux_util.cc (right):

http://codereview.chromium.org/449048/diff/2013/1014#newcode197
base/linux_util.cc:197: /* last resort */
On 2009/12/01 06:38:48, Evan Martin wrote:
> // C++-style comments

Fixed.

http://codereview.chromium.org/449048/diff/2013/1014#newcode198
base/linux_util.cc:198: return FilePath("/tmp/");
On 2009/12/01 06:38:48, Evan Martin wrote:
> I think normally we don't end paths with / ?

Fixed.

http://codereview.chromium.org/449048/diff/2013/1013
File base/linux_util.h (right):

http://codereview.chromium.org/449048/diff/2013/1013#newcode50
base/linux_util.h:50: // Wrapper around xdg_user_dir_lookup() from
src/base/third_party/xdg-user-dirs
On 2009/12/01 06:38:48, Evan Martin wrote:
> Can you describe what it does?  It looks identical to the function above it
(?)

Ok, done.

http://codereview.chromium.org/449048/diff/2013/1016
File chrome/browser/profile.cc (right):

http://codereview.chromium.org/449048/diff/2013/1016#newcode615
chrome/browser/profile.cc:615: PathService::Get(base::DIR_USER_CACHE,
&base_cache_path_);
On 2009/12/01 06:38:48, Evan Martin wrote:
> Hm, interesting, so USER_CACHE now returns the top-level cache dir but not the
> Chrome-specific one?  I wonder how useful that is for other platforms...

Mac reinvented the wheel with DIR_CACHE. I will merge in a separate CL. Since
this code is now in base, I wanted to make it generic.

[Evan Martin, 2009-12-01 20:26:53]

LGTM if it passes trybots

http://codereview.chromium.org/449048/diff/6001/6003
File base/base_paths.h (right):

http://codereview.chromium.org/449048/diff/6001/6003#newcode34
base/base_paths.h:34: DIR_USER_CACHE,   // directory where user cache data
resides.
This still isn't quite specific enough for me -- can you mention that it's
explicitly not the Chrome cache dir?

http://codereview.chromium.org/449048/diff/6001/6008
File chrome/common/chrome_paths_linux.cc (right):

http://codereview.chromium.org/449048/diff/6001/6008#newcode46
chrome/common/chrome_paths_linux.cc:46: *result =
base::GetXDGUserDirectory(env.get(), "DOCUMENTS", "Documents");
It is too bad that this API requires all this scoped_ptr business.

[Lei Zhang, 2009-12-02 08:23:52]

I think this is safe to commit. Will try in the middle of the night when no
one's around.

http://codereview.chromium.org/449048/diff/6001/6003
File base/base_paths.h (right):

http://codereview.chromium.org/449048/diff/6001/6003#newcode34
base/base_paths.h:34: DIR_USER_CACHE,   // directory where user cache data
resides.
On 2009/12/01 20:26:53, Evan Martin wrote:
> This still isn't quite specific enough for me -- can you mention that it's
> explicitly not the Chrome cache dir?

Done.