Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(389)

Issue 449048: Move some XDG code from chrome to base. (Closed)

Created:
11 years ago by Lei Zhang
Modified:
9 years, 7 months ago
Reviewers:
Evan Martin, Evan Stade
CC:
chromium-reviews_googlegroups.com, brettw+cc_chromium.org, ben+cc_chromium.org, pam+watch_chromium.org, John Grabowski
Visibility:
Public.

Description

Move some XDG code from chrome to base, make DIR_USER_CACHE generic rather than Chromium specific, and clean up a few headers. BUG=none TEST=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=33565

Patch Set 1 #

Total comments: 1

Patch Set 2 : fix compile #

Total comments: 14

Patch Set 3 : address comments, fix windows compile some more #

Total comments: 3

Patch Set 4 : fix unit tests #

Patch Set 5 : add clarification for DIR_USER_CACHE #

Patch Set 6 : fix linux base_unittest #

Unified diffs Side-by-side diffs Delta from patch set Stats (+118 lines, -366 lines) Patch
M base/base.gyp View 1 2 3 4 2 chunks +3 lines, -0 lines 0 comments Download
M base/base_paths.h View 1 2 3 4 2 chunks +5 lines, -1 line 0 comments Download
M base/base_paths_posix.cc View 1 2 3 4 5 2 chunks +11 lines, -1 line 0 comments Download
M base/linux_util.h View 1 2 3 4 2 chunks +19 lines, -0 lines 0 comments Download
M base/linux_util.cc View 1 2 3 4 3 chunks +39 lines, -1 line 0 comments Download
M base/test/test_suite.h View 2 3 4 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/process_singleton_win.cc View 3 4 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/profile.cc View 1 2 3 4 1 chunk +15 lines, -2 lines 0 comments Download
M chrome/chrome.gyp View 1 2 3 4 2 chunks +1 line, -6 lines 0 comments Download
M chrome/common/chrome_paths.h View 1 2 3 4 1 chunk +0 lines, -1 line 0 comments Download
M chrome/common/chrome_paths.cc View 1 2 3 4 1 chunk +0 lines, -10 lines 0 comments Download
M chrome/common/chrome_paths_internal.h View 1 2 3 4 1 chunk +0 lines, -5 lines 0 comments Download
M chrome/common/chrome_paths_linux.cc View 1 2 3 4 5 chunks +20 lines, -70 lines 0 comments Download
D chrome/third_party/xdg_user_dirs/README.chromium View 1 2 3 4 1 chunk +0 lines, -3 lines 0 comments Download
D chrome/third_party/xdg_user_dirs/xdg_user_dir_lookup.h View 1 2 3 4 1 chunk +0 lines, -33 lines 0 comments Download
D chrome/third_party/xdg_user_dirs/xdg_user_dir_lookup.cc View 1 2 3 4 1 chunk +0 lines, -232 lines 0 comments Download
M media/audio/win/audio_output_win_unittest.cc View 3 4 1 chunk +1 line, -0 lines 0 comments Download
M media/base/yuv_convert_unittest.cc View 2 3 4 2 chunks +1 line, -1 line 0 comments Download
M media/filters/file_data_source_unittest.cc View 2 3 4 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
Lei Zhang
I ran: svn mv chrome/third_party/xdg_user_dirs base/third_party, but I think gcl got confused. http://codereview.chromium.org/449048/diff/1/3 File base/base_paths.h ...
11 years ago (2009-12-01 04:51:40 UTC) #1
Evan Martin
Can you make the review description more descriptive? http://codereview.chromium.org/449048/diff/2013/1012 File base/base_paths.h (left): http://codereview.chromium.org/449048/diff/2013/1012#oldcode17 base/base_paths.h:17: #include ...
11 years ago (2009-12-01 06:38:48 UTC) #2
Lei Zhang
http://codereview.chromium.org/449048/diff/2013/1012 File base/base_paths.h (left): http://codereview.chromium.org/449048/diff/2013/1012#oldcode17 base/base_paths.h:17: #include "base/path_service.h" On 2009/12/01 06:38:48, Evan Martin wrote: > ...
11 years ago (2009-12-01 20:04:20 UTC) #3
Evan Martin
LGTM if it passes trybots http://codereview.chromium.org/449048/diff/6001/6003 File base/base_paths.h (right): http://codereview.chromium.org/449048/diff/6001/6003#newcode34 base/base_paths.h:34: DIR_USER_CACHE, // directory where ...
11 years ago (2009-12-01 20:26:53 UTC) #4
Lei Zhang
11 years ago (2009-12-02 08:23:52 UTC) #5
I think this is safe to commit. Will try in the middle of the night when no
one's around.

http://codereview.chromium.org/449048/diff/6001/6003
File base/base_paths.h (right):

http://codereview.chromium.org/449048/diff/6001/6003#newcode34
base/base_paths.h:34: DIR_USER_CACHE,   // directory where user cache data
resides.
On 2009/12/01 20:26:53, Evan Martin wrote:
> This still isn't quite specific enough for me -- can you mention that it's
> explicitly not the Chrome cache dir?

Done.

Powered by Google App Engine
This is Rietveld 408576698