Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(240)

Issue 449012: Introduce flag for using the fast compiler where possible.... (Closed)

Created:
11 years ago by fschneider
Modified:
9 years, 6 months ago
Reviewers:
Lasse Reichstein
CC:
v8-dev
Visibility:
Public.

Description

Introduce flag for using the fast compiler where possible. We use the fast compiler only for top-level code right now. When always_fast_compiler is set to true, we compile with the fast compiler whereever possible. By default this flag is set to false. Committed: http://code.google.com/p/v8/source/detail?r=3381

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -2 lines) Patch
M src/compiler.cc View 1 chunk +5 lines, -2 lines 2 comments Download
M src/flag-definitions.h View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
fschneider
11 years ago (2009-11-30 10:31:07 UTC) #1
Lasse Reichstein
LGTM http://codereview.chromium.org/449012/diff/1/3 File src/compiler.cc (right): http://codereview.chromium.org/449012/diff/1/3#newcode128 src/compiler.cc:128: if (shared.is_null() && !literal->scope()->is_global_scope() && Does "shared.is_null()" have ...
11 years ago (2009-11-30 11:45:53 UTC) #2
fschneider
11 years ago (2009-11-30 12:19:19 UTC) #3
http://codereview.chromium.org/449012/diff/1/3
File src/compiler.cc (right):

http://codereview.chromium.org/449012/diff/1/3#newcode128
src/compiler.cc:128: if (shared.is_null() &&
!literal->scope()->is_global_scope() &&
On 2009/11/30 11:45:53, Lasse Reichstein wrote:
> Does "shared.is_null()" have a special significance? (I.e., if it isn't there,
> what does it tell us about the function?)

Good question. I'm not sure. As I understand the SharedFunctionInfo is non-null
for lazily compiled functions. I'll leave it as is for now, but have a closer
look later.

Powered by Google App Engine
This is Rietveld 408576698