Issue 4485001: Split utils.h into utils.h and v8utils.h where the former is independent of V8.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 4485001: Split utils.h into utils.h and v8utils.h where the former is independent of V8. (Closed)

Created:
10 years, 1 month ago by Lasse Reichstein

Modified:
9 years, 6 months ago

Reviewers:
Mads Ager (chromium)

CC:
v8-dev

Visibility:
Public.

Description

Split utils.h into utils.h and v8utils.h where the former is independent of V8. The code in utils.h can be reused outside of v8 propert, as long as the propert ASSERT macros are defined.

Patch Set 2 : Addressed review comments. #

Created: 10 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+336 lines, -321 lines)			Patch
M	src/api.cc	View		1 chunk	+0 lines, -1 line	0 comments	Download
M	src/ia32/ic-ia32.cc	View		1 chunk	+0 lines, -1 line	0 comments	Download
M	src/utils.h	View	1	7 chunks	+34 lines, -281 lines	0 comments	Download
M	src/utils.cc	View		2 chunks	+0 lines, -36 lines	0 comments	Download
M	src/v8.h	View		1 chunk	+1 line, -1 line	0 comments	Download
A	src/v8utils.h	View	1	1 chunk	+301 lines, -0 lines	0 comments	Download
M	src/x64/ic-x64.cc	View		1 chunk	+0 lines, -1 line	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Mads Ager (chromium)

LGTM http://codereview.chromium.org/4485001/diff/1/5 File src/utils.h (right): http://codereview.chromium.org/4485001/diff/1/5#newcode389 src/utils.h:389: class TempAssign { Could you remove this one. ...

10 years, 1 month ago (2010-11-05 08:00:27 UTC) #2

Lasse Reichstein

10 years, 1 month ago (2010-11-05 12:32:25 UTC) #3

http://codereview.chromium.org/4485001/diff/1/5
File src/utils.h (right):

http://codereview.chromium.org/4485001/diff/1/5#newcode389
src/utils.h:389: class TempAssign {
You are probably right. I think I added it because I wanted to use it, but ended
up building more specialized scopes in every case anyway.
Removed.

http://codereview.chromium.org/4485001/diff/1/7
File src/v8utils.h (right):

http://codereview.chromium.org/4485001/diff/1/7#newcode1
src/v8utils.h:1: // Copyright 2006-2008 the V8 project authors. All rights
reserved.
Done

Expand Messages | Collapse Messages

Issue 4485001: Split utils.h into utils.h and v8utils.h where the former is independent of V8. (Closed)

Description

Patch Set 1 #

Patch Set 2 : Addressed review comments. #

Messages