Issue 4480001: Refuse to change the chronos password if already set unless explicitly asked.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 4480001: Refuse to change the chronos password if already set unless explicitly asked. (Closed)

Created:
10 years, 1 month ago by gauravsh

Modified:
9 years, 6 months ago

Reviewers:
Will Drewry

CC:
chromium-os-reviews_chromium.org, Randall Spangler, gauravsh, Luigi Semenzato, Bill Richardson

Base URL:
ssh://git@gitrw.chromium.org:9222/vboot_reference.git@master

Visibility:
Public.

Description

Refuse to change the chronos password if already set unless explicitly asked. This adds an optional --force argument which is needed if one attempts to change the password on an image where it is already set. BUG=chrome-os-partner:1460 TEST=manually tested Change-Id: I56a95fe4d699ce02c7a68e5be14cc7dce0609a54 Committed: http://chrome-svn/viewvc/chromeos?view=rev&revision=e557278

Patch Set 1 #

Patch Set 2 : fix spacing #

Total comments: 1

Patch Set 3 : review fixes #

Created: 10 years, 1 month ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+21 lines, -6 lines)			Patch
	M	scripts/image_signing/common.sh	View		1 chunk	+7 lines, -0 lines	0 comments	Download
	M	scripts/image_signing/set_chronos_password.sh	View	1 2	2 chunks	+14 lines, -6 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Will Drewry

LGTM with a nit Also, we might want to add a shadow checker to common ...

10 years, 1 month ago (2010-11-04 16:19:28 UTC) #2

gauravsh

10 years, 1 month ago (2010-11-05 20:00:27 UTC) #3

Thanks, pushed and submitted.

On Thu, Nov 4, 2010 at 9:19 AM, <wad@chromium.org> wrote:

> LGTM with a nit
>
> Also, we might want to add a shadow checker to common so we can check
> images
> prior to signing too.
>

I moved the no_chronos_password() script to common. Not sure if you prefer a
more sophisticated shadow password checker instead.

>
>
> http://codereview.chromium.org/4480001/diff/2001/3001
> File scripts/image_signing/set_chronos_password.sh (right):
>
> http://codereview.chromium.org/4480001/diff/2001/3001#newcode28
> scripts/image_signing/set_chronos_password.sh:28:
> check_chronos_password() {
> nit: I'd rename this to no_chronos_password or invert it and do
> has_chronos_password().


Done.


>
> http://codereview.chromium.org/4480001/show
>



-- 
-g

Expand Messages | Collapse Messages