Add sanity checks of the BDIC files to ConvertDictTest....

Add sanity checks of the BDIC files to Chrome.
This change updates ConvertDictTest that trims the end of BDICTs and verify hunspell::BDict::Verify() treats the trimmed BDICTs as corrupted. (This is a Chromium-side change of r65351 <http://crrev.com/65351>.)

BUG=61206
TEST=unit_tests.exe --gtest_filter=ConvertDictTest.*

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=66098

[jungshik at Google, 2010-11-04 21:28:43]

Looks like you have another file with  changes that you forgot to upload here
:-)

[Hironori Bono, 2010-11-05 09:30:25]

On 2010/11/04 21:28:43, Jungshik Shin wrote:
> Looks like you have another file with  changes that you forgot to upload here
> :-)

Sorry for the lack of explanation. This is the chromium-side change for
<http://codereview.chromium.org/4409002>, i.e. we need to land the change and
merge it to the Chromium tree.

Regards,

Hironori Bono

[Evan Stade, 2010-11-05 18:56:13]

if we detect corruption while using the dictionary (i.e. your FindWord fix), it
might be nice to send that info back to the spellcheck host so it can run verify
again (at most once per dictionary per browser session) and delete the
dictionary if it's corrupted.

[jungshik at Google, 2010-11-05 19:35:54]

On 2010/11/05 09:30:25, hbono wrote:
> On 2010/11/04 21:28:43, Jungshik Shin wrote:
> > Looks like you have another file with  changes that you forgot to upload
here
> > :-)
> 
> Sorry for the lack of explanation. This is the chromium-side change for
> <http://codereview.chromium.org/4409002>, i.e. we need to land the change and
> merge it to the Chromium tree.

Thank you for the explanation. Sorry I forgot that hunspell is in a separate
tree/module. Can you reference that CL in the description of this CL?  


> 
> Regards,
> 
> Hironori Bono

[Hironori Bono, 2010-11-11 04:10:21]

Greetings Evan and Jungshik,

On 2010/11/05 18:56:13, Evan Stade wrote:

> if we detect corruption while using the dictionary (i.e.
> your FindWord fix), it might be nice to send that info back
> to the spellcheck host so it can run verify again (at most
> once per dictionary per browser session) and delete the
> dictionary if it's corrupted.

Thank you for your comments and sorry for my slow response. The current our
hunspell implementation does not provide reasons why a hunspell::spell() call
returns 0, i.e. Chrome cannot figure out why an input word is treated as
misspelled word. I'm writing another hunspell change that adds an error code to
BDictReader to tell Chrome the BDict is corrupted as its first step.

On 2010/11/05 19:35:54, Jungshik Shin wrote:

> Thank you for the explanation. Sorry I forgot that hunspell is in
> a separate tree/module. Can you reference that CL in the
> description of this CL?  

Done. Thank you for noticing it.

Regards,

Hironori Bono

[Evan Stade, 2010-11-11 23:17:46]

lgtm