Add VideoPacket struct for video packets. Refactor Decode interface to use it.

remoting/client/chromoting_client.h

 // Copyright (c) 2010 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 // ChromotingClient is the controller for the Client implementation.
 
 #ifndef REMOTING_CLIENT_CHROMOTING_CLIENT_H
 #define REMOTING_CLIENT_CHROMOTING_CLIENT_H
 
 #include <list>
 
 #include "base/task.h"
 #include "remoting/client/client_config.h"
 #include "remoting/client/chromoting_view.h"
 #include "remoting/protocol/connection_to_host.h"
 #include "remoting/protocol/video_stub.h"
 
 class MessageLoop;
 
 namespace remoting {
 
-class ChromotingHostMessage;
 class ClientContext;
-class InitClientMessage;
 class InputHandler;
 class RectangleUpdateDecoder;
 
 // TODO(sergeyu): Move VideoStub implementation to RectangleUpdateDecoder.
 class ChromotingClient : public protocol::ConnectionToHost::HostEventCallback,
                          public protocol::VideoStub {
  public:
   // Objects passed in are not owned by this class.
   ChromotingClient(const ClientConfig& config,
                    ClientContext* context,
@@ skipping 13 matching lines @@
 
   // Sets the viewport to do display.  The viewport may be larger and/or
   // smaller than the actual image background being displayed.
   //
   // TODO(ajwong): This doesn't make sense to have here.  We're going to have
   // threading isseus since pepper view needs to be called from the main pepper
   // thread synchronously really.
   virtual void SetViewport(int x, int y, int width, int height);
 
   // ConnectionToHost::HostEventCallback implementation.
-  virtual void HandleMessage(protocol::ConnectionToHost* conn,
-                             ChromotingHostMessage* messages);
   virtual void OnConnectionOpened(protocol::ConnectionToHost* conn);
   virtual void OnConnectionClosed(protocol::ConnectionToHost* conn);
   virtual void OnConnectionFailed(protocol::ConnectionToHost* conn);
 
   // VideoStub implementation.
   virtual void ProcessVideoPacket(const VideoPacket* packet, Task* done);
 
  private:
   struct QueuedVideoPacket {
     QueuedVideoPacket(const VideoPacket* packet, Task* done)
         : packet(packet), done(done) {
     }
     const VideoPacket* packet;
     Task* done;
   };
 
   MessageLoop* message_loop();
 
+  // Initializes connection.
+  void Initialize();

[awong, 2010/11/09 01:54:38]

Minor annoyance unrelated to this CL, but we should settle on Init versus
Initialize.  I think Initialize() is winning.

ajwong@ajwong:~/src/git-chrome/src$ find remoting/ -name '*.h' -exec grep -H
Init\(\) {} \; | grep -v ': *//'  | wc -l
2
ajwong@ajwong:~/src/git-chrome/src$ find remoting/ -name '*.h' -exec grep -H
Initialize\(\) {} \; | grep -v ': *//'  | wc -l
6

[Sergey Ulanov, 2010/11/09 21:34:42]

Agree

+
   // Convenience method for modifying the state on this object's message loop.
   void SetConnectionState(ConnectionState s);
 
   // If a packet is not being processed, dispatches a single message from the
   // |received_packets_| queue.
   void DispatchPacket();
 
   void OnPacketDone();
 
-  // Handles for chromotocol messages.
-  void InitClient(const InitClientMessage& msg);
-
   // The following are not owned by this class.
   ClientConfig config_;
   ClientContext* context_;
   protocol::ConnectionToHost* connection_;
   ChromotingView* view_;
   RectangleUpdateDecoder* rectangle_decoder_;
   InputHandler* input_handler_;
 
   // If non-NULL, this is called when the client is done.
   CancelableTask* client_done_;
@@ skipping 11 matching lines @@
   bool packet_being_processed_;
 
   DISALLOW_COPY_AND_ASSIGN(ChromotingClient);
 };
 
 }  // namespace remoting
 
 DISABLE_RUNNABLE_METHOD_REFCOUNT(remoting::ChromotingClient);
 
 #endif  // REMOTING_CLIENT_CHROMOTING_CLIENT_H