Issue 4469002: Improve positions recording for calls.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 4469002: Improve positions recording for calls. (Closed)

Created:
10 years, 1 month ago by Vyacheslav Egorov (Chromium)

Modified:
9 years, 7 months ago

Reviewers:
Søren Thygesen Gjesse

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

Description

Improve positions recording for calls. Committed: http://code.google.com/p/v8/source/detail?r=5768

Patch Set 1 #

Total comments: 2

Created: 10 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+489 lines, -365 lines)			Patch
M	src/arm/assembler-arm.h	View	3 chunks	+15 lines, -12 lines	0 comments	Download
M	src/arm/assembler-arm.cc	View	8 chunks	+9 lines, -53 lines	1 comment	Download
M	src/arm/full-codegen-arm.cc	View	7 chunks	+71 lines, -49 lines	0 comments	Download
M	src/arm/macro-assembler-arm.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	src/assembler.h	View	1 chunk	+61 lines, -0 lines	1 comment	Download
M	src/assembler.cc	View	1 chunk	+49 lines, -0 lines	0 comments	Download
M	src/codegen.cc	View	3 chunks	+7 lines, -6 lines	0 comments	Download
M	src/full-codegen.h	View	1 chunk	+3 lines, -1 line	0 comments	Download
M	src/full-codegen.cc	View	1 chunk	+3 lines, -2 lines	0 comments	Download
M	src/ia32/assembler-ia32.h	View	3 chunks	+5 lines, -11 lines	0 comments	Download
M	src/ia32/assembler-ia32.cc	View	5 chunks	+5 lines, -49 lines	0 comments	Download
M	src/ia32/codegen-ia32.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	src/ia32/full-codegen-ia32.cc	View	7 chunks	+60 lines, -45 lines	0 comments	Download
M	src/jump-target-heavy.cc	View	1 chunk	+3 lines, -2 lines	0 comments	Download
M	src/jump-target-light.cc	View	1 chunk	+3 lines, -2 lines	0 comments	Download
M	src/x64/assembler-x64.h	View	2 chunks	+4 lines, -11 lines	0 comments	Download
M	src/x64/assembler-x64.cc	View	5 chunks	+5 lines, -49 lines	0 comments	Download
M	src/x64/codegen-x64.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	src/x64/full-codegen-x64.cc	View	7 chunks	+88 lines, -70 lines	0 comments	Download
A	test/mjsunit/regress/regress-conditional-position.js	View	1 chunk	+95 lines, -0 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Søren Thygesen Gjesse

10 years, 1 month ago (2010-11-04 15:08:23 UTC) #2

LGTM

Thanks for refactoring duplicated code while fixing this bug.

http://codereview.chromium.org/4469002/diff/1/2
File src/arm/assembler-arm.cc (right):

http://codereview.chromium.org/4469002/diff/1/2#newcode999
src/arm/assembler-arm.cc:999: positions_recorder()->WriteRecordedPositions();
Why not just positions_recorder_. instead of positions_recorder()->?

http://codereview.chromium.org/4469002/diff/1/7
File src/assembler.h (right):

http://codereview.chromium.org/4469002/diff/1/7#newcode590
src/assembler.h:590: enum PositionRecordingType { FORCED_POSITION,
NORMAL_POSITION };
Thanks for using an enum instead of a boolean.

Expand Messages | Collapse Messages