Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(686)

Issue 4464005: Update the error page template to be a little prettier. (Closed)

Created:
10 years, 1 month ago by mmenke
Modified:
9 years, 7 months ago
CC:
chromium-reviews, darin-cc_chromium.org, brettw-cc_chromium.org, tony
Visibility:
Public.

Description

Update the error page template to be a little prettier. Based on a combination of the malware pages and the link doctor page. Also removes the "more details" expander. Inlines the details using a lighter font color instead. Screenshots: https://docs3.google.com/document/d/1GdqTtkl_gjWg1GYRNxBGToy63mwEHCAZlXGKHCk_wYw/edit?hl=en# BUG=59096 TEST=Manual Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=65344

Patch Set 1 : '' #

Total comments: 10

Patch Set 2 : Response to comments, added left out files #

Patch Set 3 : Sync with trunk #

Unified diffs Side-by-side diffs Delta from patch set Stats (+67 lines, -97 lines) Patch
M chrome/app/generated_resources.grd View 2 1 chunk +0 lines, -6 lines 0 comments Download
M chrome/renderer/localized_error.cc View 2 1 chunk +0 lines, -6 lines 0 comments Download
M chrome/renderer/resources/neterror.html View 1 2 2 chunks +67 lines, -85 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
mmenke
Glen has already approved the page's new appearance.
10 years, 1 month ago (2010-11-04 15:21:28 UTC) #1
arv (Not doing code reviews)
purty http://codereview.chromium.org/4464005/diff/6001/7001 File chrome/renderer/resources/neterror.html (right): http://codereview.chromium.org/4464005/diff/6001/7001#newcode15 chrome/renderer/resources/neterror.html:15: margin: 0px; s/0px/0/ http://codereview.chromium.org/4464005/diff/6001/7001#newcode18 chrome/renderer/resources/neterror.html:18: border-top: solid 1px ...
10 years, 1 month ago (2010-11-04 19:15:18 UTC) #2
mmenke
Thanks. Hadn't even considered how horizontal margins would affect rtl pages. Taken a look at ...
10 years, 1 month ago (2010-11-04 20:08:02 UTC) #3
arv (Not doing code reviews)
10 years, 1 month ago (2010-11-04 22:18:09 UTC) #4
LGTM

Powered by Google App Engine
This is Rietveld 408576698