Issue 4451001: chrome_exe_main: name os-specific files according to naming pattern

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 4451001: chrome_exe_main: name os-specific files according to naming pattern (Closed)

Created:
10 years, 1 month ago by Evan Martin

Modified:
9 years, 7 months ago

Reviewers:
tony, tfarina

CC:
chromium-reviews, pam+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src/chrome

Visibility:
Public.

chrome_exe_main: name os-specific files according to naming pattern These files probably just predate us having a _win suffix on Windows-specific code. BUG=18504 TEST=compiles Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=65001

Created: 10 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+17 lines, -16 lines)			Patch
M	chrome/app/chrome_dll_main.cc	View	1 chunk	+6 lines, -5 lines	0 comments	Download
M	chrome/app/chrome_exe_main_gtk.cc	View	1 chunk	+3 lines, -3 lines	0 comments	Download
A +	chrome/app/chrome_exe_main_mac.mm	View	0 chunks	+-1 lines, --1 lines	0 comments	Download
A +	chrome/app/chrome_exe_main_win.cc	View	0 chunks	+-1 lines, --1 lines	0 comments	Download
M	chrome/chrome.gyp	View	1 chunk	+8 lines, -7 lines	0 comments	Download
M	chrome/chrome_exe.gypi	View	2 chunks	+2 lines, -3 lines	0 comments	Download

Total messages: 3 (0 generated)

Evan Martin

(mostly this is renaming some files, which the diff doesn't show too well. foo.cc -> ...

10 years, 1 month ago (2010-11-04 00:07:56 UTC) #1

LGTM