Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(270)

Issue 445002: Switch to GPT partition format.

Created:
11 years ago by tedbo
Modified:
11 years ago
Reviewers:
adlr
CC:
chromium-os-reviews_googlegroups.com
Visibility:
Public.

Description

Switch to GPT partition format. This changes switches to using the GPT partition format. The GPT format is more modern and flexible. It allows us to create up to 128 partitions, has a crc on the partition table data, and has a backup partition. It should also make it easier for us to incorporate a boot loader directly in firmware (if we use EFI) since GPT is the recommended format. The image_to_usb and chromeos_install scripts have been modified to use a common set of shell functions to create a bootable image. The common functions can create a bootable image given a rootfs or rootfs partition with output to a file or device. This simplifies image_to_usb and the installer while at the same time keeps the code to create a bootable image from a rootfs in one place. We also allow for setting the size of the stateful partition. The default for a minimal partition setup allows us to use smaller USB keyfobs as an output target if we want. The work of partitioning is done by calling the bsd-ported gpt partitioning utility, which works on a file or device. In order to support legacy BIOS on x86, we use the syslinux gpt "New protocol" with gptmbr.bin. See the gpt.txt file in the syslinux doc directory.

Patch Set 1 #

Total comments: 3

Patch Set 2 : Output all dependencies needed to create a bootable image to the output directory. #

Patch Set 3 : Address adlr comment #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+360 lines, -315 lines) Patch
M src/platform/installer/chromeos_install.sh View 4 chunks +31 lines, -114 lines 0 comments Download
A src/platform/installer/chromeos_install_functions.sh View 1 2 1 chunk +269 lines, -0 lines 0 comments Download
M src/platform/installer/debian/control View 1 chunk +1 line, -1 line 0 comments Download
M src/platform/installer/debian/rules View 1 chunk +2 lines, -0 lines 0 comments Download
M src/scripts/build_image.sh View 1 2 chunks +19 lines, -14 lines 1 comment Download
M src/scripts/common.sh View 4 chunks +9 lines, -5 lines 0 comments Download
D src/scripts/file_copy.py View 1 chunk +0 lines, -100 lines 0 comments Download
M src/scripts/image_to_usb.sh View 1 3 chunks +29 lines, -81 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
tedbo
11 years ago (2009-11-26 01:41:41 UTC) #1
adlr
http://codereview.chromium.org/445002/diff/1/2 File src/platform/installer/chromeos_install.sh (right): http://codereview.chromium.org/445002/diff/1/2#newcode9 src/platform/installer/chromeos_install.sh:9: echo "" do you want to check if the ...
11 years ago (2009-12-11 22:23:18 UTC) #2
adlr
11 years ago (2009-12-17 08:17:52 UTC) #3
LGTM w/ comment

http://codereview.chromium.org/445002/diff/3002/3007
File src/scripts/build_image.sh (right):

http://codereview.chromium.org/445002/diff/3002/3007#newcode268
src/scripts/build_image.sh:268: # Copy utilities needed to create a bootable
image to the output directory.
would it be easier (or more future proof?) to just copy the whole scripts
directory?

Powered by Google App Engine
This is Rietveld 408576698