Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(51)

Issue 4449001: Add 0.0.1 logic to new cros_mark. (Closed)

Created:
10 years, 1 month ago by sosa
Modified:
9 years, 6 months ago
Reviewers:
davidjames, anush
CC:
chromium-os-reviews_chromium.org, Mandeep Singh Baines, anush, sosa
Visibility:
Public.

Description

Add 0.0.1 logic to new cros_mark. Change-Id: I413d21dd60ce822af65d5c7c22fd2dba67858d43 BUG=6113 TEST=Ran unit tests and also created my own 9999 ebuild and ran with --all and saw 0.0.1-r1.ebuild get created in stabilizing_branch Committed: http://chrome-svn/viewvc/chromeos?view=rev&revision=de285e0

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+20 lines, -12 lines) Patch
M cros_mark_as_stable.py View 5 chunks +15 lines, -8 lines 0 comments Download
M cros_mark_as_stable_unittest.py View 4 chunks +5 lines, -4 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
sosa
10 years, 1 month ago (2010-11-03 23:54:39 UTC) #1
sosa
Ping? On Wed, Nov 3, 2010 at 4:54 PM, <sosa@chromium.org> wrote: > Reviewers: David James, ...
10 years, 1 month ago (2010-11-04 17:14:05 UTC) #2
davidjames
LGTM
10 years, 1 month ago (2010-11-04 17:38:45 UTC) #3
sosa
Let me know which branches to check this into as well if any On Thu, ...
10 years, 1 month ago (2010-11-04 18:01:56 UTC) #4
anush
lets leave R9 out of the picture for all but critical fixes. From a build/infra ...
10 years, 1 month ago (2010-11-04 18:05:08 UTC) #5
sosa
10 years, 1 month ago (2010-11-04 19:05:00 UTC) #6
Sure, makes my life easier :)

On Thu, Nov 4, 2010 at 11:05 AM, Anush Elangovan(அனுஷ்)
<anush@chromium.org> wrote:
> lets leave R9 out of the picture for all but critical fixes. From a
> build/infra perspective we should consider R9 done, so please commit
> to master.
> (there are exceptions to the rule if you rely/change interfaces to
> cbuild since it isn't branched)
>
>
> On Thu, Nov 4, 2010 at 11:01 AM, Chris Sosa <sosa@chromium.org> wrote:
>> Let me know which branches to check this into as well if any
>>
>> On Thu, Nov 4, 2010 at 10:38 AM,  <davidjames@chromium.org> wrote:
>>> LGTM
>>>
>>> http://codereview.chromium.org/4449001/show
>>>
>>
>

Powered by Google App Engine
This is Rietveld 408576698