Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(167)

Issue 4448003: Implement onCompleted event for the webNavigation API (Closed)

Created:
10 years, 1 month ago by jochen (gone - plz use gerrit)
Modified:
9 years, 7 months ago
Reviewers:
yzshen, Matt Perry
CC:
chromium-reviews, nkostylev+cc_chromium.org, ben+cc_chromium.org, Erik does not do reviews, Paweł Hajdan Jr., Aaron Boodman, pam+watch_chromium.org, brettw-cc_chromium.org, darin-cc_chromium.org, davemoore+watch_chromium.org
Visibility:
Public.

Description

Implement onCompleted event for the webNavigation API BUG=50943 TEST=browser_tests:*.WebNavigationEvents* Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=65182

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+159 lines, -1 line) Patch
M chrome/browser/chromeos/login/web_page_view.h View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/chromeos/login/web_page_view.cc View 1 chunk +4 lines, -0 lines 0 comments Download
M chrome/browser/extensions/extension_webnavigation_api.h View 1 chunk +4 lines, -0 lines 0 comments Download
M chrome/browser/extensions/extension_webnavigation_api.cc View 3 chunks +27 lines, -0 lines 0 comments Download
M chrome/browser/renderer_host/render_view_host.h View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/renderer_host/render_view_host.cc View 2 chunks +9 lines, -0 lines 0 comments Download
M chrome/browser/renderer_host/render_view_host_delegate.h View 1 chunk +3 lines, -0 lines 0 comments Download
M chrome/browser/tab_contents/tab_contents.h View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/tab_contents/tab_contents.cc View 1 chunk +7 lines, -0 lines 0 comments Download
M chrome/common/notification_type.h View 1 chunk +5 lines, -0 lines 0 comments Download
M chrome/common/render_messages_internal.h View 1 chunk +4 lines, -0 lines 0 comments Download
M chrome/renderer/render_view.cc View 1 chunk +2 lines, -0 lines 0 comments Download
M chrome/test/data/extensions/api_test/webnavigation/navigation1/test.html View 12 chunks +70 lines, -0 lines 0 comments Download
M chrome/test/data/extensions/api_test/webnavigation/navigation2/test.html View 3 chunks +21 lines, -1 line 0 comments Download

Messages

Total messages: 4 (0 generated)
jochen (gone - plz use gerrit)
please review
10 years, 1 month ago (2010-11-04 12:12:45 UTC) #1
yzshen
LGTM Please wait for Matt's comments before submitting.
10 years, 1 month ago (2010-11-04 17:19:06 UTC) #2
Matt Perry
LGTM. I wonder if we should disable all this navigation tracking if there are no ...
10 years, 1 month ago (2010-11-04 18:31:34 UTC) #3
jochen (gone - plz use gerrit)
10 years, 1 month ago (2010-11-04 19:21:53 UTC) #4
On 2010/11/04 18:31:34, Matt Perry wrote:
> LGTM.
> 
> I wonder if we should disable all this navigation tracking if there are no
> extensions using the webNavigation API. Probably not worth the effort just for
> frame loads, but once we get to the webRequest API we might see an impact.

the extension service only forwards events if there's at least one registered
listener. The json data still gets build everytime, so it might be worthwhile
for the web request api to optimize this even further.

Powered by Google App Engine
This is Rietveld 408576698