Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(67)

Issue 4445001: Reenabling the ChromeFrame test FullTabModeIE_WindowClose which failed becaus... (Closed)

Created:
10 years, 1 month ago by ananta
Modified:
9 years, 6 months ago
Reviewers:
amit
CC:
chromium-reviews, amit
Visibility:
Public.

Description

Reenabling the ChromeFrame test FullTabModeIE_WindowClose which failed because the type lib needs to be generated and included in the chrome frame binary. This may need a clobber. Bug=61011 TBR=amit Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=64989

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -5 lines) Patch
M chrome_frame/test/test_with_web_server.cc View 1 chunk +1 line, -5 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
ananta
10 years, 1 month ago (2010-11-03 23:32:39 UTC) #1
amit
10 years, 1 month ago (2010-11-03 23:33:14 UTC) #2
OK, thanks

On Wed, Nov 3, 2010 at 4:32 PM, <ananta@chromium.org> wrote:

> Reviewers: amit,
>
> Description:
> Reenabling the ChromeFrame test FullTabModeIE_WindowClose which failed
> because
> the type
> lib needs to be generated and included in the chrome frame binary. This may
> need
> a clobber.
>
> Bug=61011
> TBR=amit
>
>
> Please review this at http://codereview.chromium.org/4445001/show
>
> SVN Base: svn://svn.chromium.org/chrome/trunk/src/
>
> Affected files:
>  M     chrome_frame/test/test_with_web_server.cc
>
>
> Index: chrome_frame/test/test_with_web_server.cc
> ===================================================================
> --- chrome_frame/test/test_with_web_server.cc   (revision 64688)
> +++ chrome_frame/test/test_with_web_server.cc   (working copy)
> @@ -1004,11 +1004,7 @@
>  const wchar_t kWindowCloseTestUrl[] =
>     L"window_close.html";
>
> -// This test causes IE to display an infobar on IE7 and IE8 on Vista and
> -// Windows 7 at least which causes this test to fail. Disabling it for
> -// now.
> -// http://code.google.com/p/chromium/issues/detail?id=61011
> -TEST_F(ChromeFrameTestWithWebServer, DISABLED_FullTabModeIE_WindowClose) {
> +TEST_F(ChromeFrameTestWithWebServer, FullTabModeIE_WindowClose) {
>   SimpleBrowserTest(IE, kWindowCloseTestUrl);
>  }
>
>
>
>

Powered by Google App Engine
This is Rietveld 408576698