Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(921)

Unified Diff: bin/cbuildbot_unittest.py

Issue 4442001: Add more error checking to preflight queue. (Closed) Base URL: ssh://git@gitrw.chromium.org:9222/crosutils.git
Patch Set: Update cros_mark_as_stable.py to run outside chroot Created 10 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: bin/cbuildbot_unittest.py
diff --git a/bin/cbuildbot_unittest.py b/bin/cbuildbot_unittest.py
index bbbc56c6f73e9a363f9cf048b20f4064034b0b70..ee2c5240c8d7788187eeebe9320820974fc951f8 100755
--- a/bin/cbuildbot_unittest.py
+++ b/bin/cbuildbot_unittest.py
@@ -166,15 +166,16 @@ class CBuildBotTest(mox.MoxTestBase):
m_file.read().AndReturn(self._test_string)
m_file.close()
+ overlays = [ '%s/src/third_party/chromiumos-overlay' % self._buildroot ]
cbuildbot.RunCommand(['./cros_mark_as_stable', '--all',
'--board=%s' % self._test_board,
- '--tracking_branch="cros/master"', 'commit'],
- cwd='%s/src/scripts' % self._buildroot,
- enter_chroot=True)
+ '--overlays=%s' % ':'.join(overlays),
+ '--tracking_branch=cros/master', 'commit'],
+ cwd='%s/src/scripts' % self._buildroot)
self.mox.ReplayAll()
cbuildbot._UprevPackages(self._buildroot, self.tracking_branch,
- self._revision_file, self._test_board)
+ self._revision_file, self._test_board, overlays)
self.mox.VerifyAll()
def testUprevAllPackages(self):
@@ -187,15 +188,17 @@ class CBuildBotTest(mox.MoxTestBase):
m_file.read().AndReturn('None')
m_file.close()
+ overlays = [ '%s/src/third_party/chromiumos-overlay' % self._buildroot ]
cbuildbot.RunCommand(['./cros_mark_as_stable', '--all',
'--board=%s' % self._test_board,
- '--tracking_branch="cros/master"', 'commit'],
- cwd='%s/src/scripts' % self._buildroot,
- enter_chroot=True)
+ '--overlays=%s' % ':'.join(overlays),
+ '--tracking_branch=cros/master', 'commit'],
+ cwd='%s/src/scripts' % self._buildroot)
self.mox.ReplayAll()
+ overlays = [ '%s/src/third_party/chromiumos-overlay' % self._buildroot ]
cbuildbot._UprevPackages(self._buildroot, self.tracking_branch,
- self._revision_file, self._test_board)
+ self._revision_file, self._test_board, overlays)
self.mox.VerifyAll()

Powered by Google App Engine
This is Rietveld 408576698