Fix bug in the fast compiler's object literal code...

Fix bug in the fast compiler's object literal code

Fixes issue 526:

BUG=http://code.google.com/p/v8/issues/detail?id=526

The object literals code in the fast compiler returned an incorrect result 
when getter or setters are defined together with computed properties.

Added a regression test that captures the most reduced version of this
problem. 

Also added a test for object literals with getters/setters and 
prototype properties.



Committed: http://code.google.com/p/v8/source/detail?r=3370

[fschneider, 2009-11-25 19:43:40]

Here is the fix - DevToolsSanityTest.* passes now :)

I also re-enabled the fast compiler. Or should this better be a separate change?

[Lasse Reichstein, 2009-11-26 08:15:18]

LGTM

http://codereview.chromium.org/444001/diff/8/1013
File src/arm/fast-codegen-arm.cc (right):

http://codereview.chromium.org/444001/diff/8/1013#newcode579
src/arm/fast-codegen-arm.cc:579: //  stack and in eax.
eax -> r0

http://codereview.chromium.org/444001/diff/8/1013#newcode580
src/arm/fast-codegen-arm.cc:580: // If result_saved == false: The result not on
the stack, just in eax.
ditto.

http://codereview.chromium.org/444001/diff/8/1012
File src/x64/fast-codegen-x64.cc (right):

http://codereview.chromium.org/444001/diff/8/1012#newcode584
src/x64/fast-codegen-x64.cc:584: //  stack and in eax.
eax->rax

http://codereview.chromium.org/444001/diff/8/1012#newcode585
src/x64/fast-codegen-x64.cc:585: // If result_saved == false: The result not on
the stack, just in eax.
ditto.

http://codereview.chromium.org/444001/diff/8/1012#newcode610
src/x64/fast-codegen-x64.cc:610: __ movq(rax, Operand(rsp, 0));  // Restore
result back into eax.
eax->rax.

[fschneider, 2009-11-26 21:03:51]

http://codereview.chromium.org/444001/diff/8/1013
File src/arm/fast-codegen-arm.cc (right):

http://codereview.chromium.org/444001/diff/8/1013#newcode579
src/arm/fast-codegen-arm.cc:579: //  stack and in eax.
On 2009/11/26 08:15:18, Lasse Reichstein wrote:
> eax -> r0

Done.

http://codereview.chromium.org/444001/diff/8/1013#newcode580
src/arm/fast-codegen-arm.cc:580: // If result_saved == false: The result not on
the stack, just in eax.
On 2009/11/26 08:15:18, Lasse Reichstein wrote:
> ditto.

Done.

http://codereview.chromium.org/444001/diff/8/1012
File src/x64/fast-codegen-x64.cc (right):

http://codereview.chromium.org/444001/diff/8/1012#newcode584
src/x64/fast-codegen-x64.cc:584: //  stack and in eax.
On 2009/11/26 08:15:18, Lasse Reichstein wrote:
> eax->rax

Done.

http://codereview.chromium.org/444001/diff/8/1012#newcode585
src/x64/fast-codegen-x64.cc:585: // If result_saved == false: The result not on
the stack, just in eax.
On 2009/11/26 08:15:18, Lasse Reichstein wrote:
> ditto.

Done.

http://codereview.chromium.org/444001/diff/8/1012#newcode610
src/x64/fast-codegen-x64.cc:610: __ movq(rax, Operand(rsp, 0));  // Restore
result back into eax.
On 2009/11/26 08:15:18, Lasse Reichstein wrote:
> eax->rax.

Done.