Issue 4435001: Add support for the extended header parameter syntax in Content-Disposition h...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 4435001: Add support for the extended header parameter syntax in Content-Disposition h... (Closed)

Created:
10 years, 1 month ago by jungshik at Google

Modified:
9 years, 7 months ago

Reviewers:

CC:
chromium-reviews, cbentzel+watch_chromium.org, brettw-cc_chromium.org, darin-cc_chromium.org, jshin+watch_chromium.org, Paweł Hajdan Jr.

Base URL:
svn://svn.chromium.org/chrome/trunk/src/

Visibility:
Public.

Description

Add support for the extended header parameter syntax in Content-Disposition header (RFC 5987). It's not generic, but is only used for 'filename' param. The CL is originally by James Simonsen I reviewed at http://codereview.chromium.org/4254001/show I added a check for ASCIIness for RFC 5987 extended header and a few tests to NetUti*.GetFileNameFromCD (net_unittests) and I*.ConvertCo*Norma* (base_unittests). I also replaced '\uxxxx' notation with the corresponding UTF-8 byte sequence because Visual Studio does not understand it yet. BUG=57830 TEST="net_unittests --gtest_filter=NetU*.GetFil*", "base_unittests --gtest_filter=I*.Conver*Norm*" and tests at http://greenbytes.de/tech/tc2231/ Original CL / Review: By James Simonsen; at http://codereview.chromium.org/4254001/show Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=64987

Patch Set 1 #

Created: 10 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+265 lines, -25 lines)			Patch
M	base/i18n/icu_string_conversions.h	View	1 chunk	+6 lines, -0 lines	0 comments	Download
M	base/i18n/icu_string_conversions.cc	View	2 chunks	+26 lines, -0 lines	0 comments	Download
M	base/i18n/icu_string_conversions_unittest.cc	View	2 chunks	+30 lines, -0 lines	0 comments	Download
M	net/base/net_util.h	View	2 chunks	+23 lines, -8 lines	0 comments	Download
M	net/base/net_util.cc	View	4 chunks	+68 lines, -12 lines	0 comments	Download
M	net/base/net_util_unittest.cc	View	4 chunks	+110 lines, -4 lines	0 comments	Download
M	webkit/glue/weburlloader_impl.cc	View	1 chunk	+2 lines, -1 line	0 comments	Download