Issue 4434001: Add a suppression for CallMyActivateTSMDocument.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 4434001: Add a suppression for CallMyActivateTSMDocument. (Closed)

Created:
10 years, 1 month ago by Robert Sesek

Modified:
9 years, 7 months ago

Reviewers:
Nico

CC:
chromium-reviews, Timur Iskhodzhanov, Alexander Potapenko, pam+watch_chromium.org, stuartmorgan+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

Description

Add a suppression for CallMyActivateTSMDocument. BUG=61816 TEST=Mac Valgrind goes green Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=64982

Patch Set 1 #

Created: 10 years, 1 month ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+20 lines, -1 line)			Patch
	M	tools/valgrind/memcheck/suppressions_mac.txt	View		1 chunk	+20 lines, -1 line	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Robert Sesek

Leaving this in cat 3 (Chromium bugs) until I can definitively rule us out. It ...

10 years, 1 month ago (2010-11-03 22:12:11 UTC) #1

Nico

10 years, 1 month ago (2010-11-03 22:14:35 UTC) #2

LG

Thanks for maki

On Wed, Nov 3, 2010 at 6:12 PM,  <rsesek@chromium.org> wrote:
> Reviewers: Nico,
>
> Message:
> Leaving this in cat 3 (Chromium bugs) until I can definitively rule us out.
> It
> does not show up just
>
> Description:
> Add a suppression for CallMyActivateTSMDocument.
>
> BUG=61816
> TEST=Mac Valgrind goes green
>
> Please review this at http://codereview.chromium.org/4434001/show
>
> SVN Base: svn://svn.chromium.org/chrome/trunk/src
>
> Affected files:
>  M tools/valgrind/memcheck/suppressions_mac.txt
>
>
> Index: tools/valgrind/memcheck/suppressions_mac.txt
> diff --git a/tools/valgrind/memcheck/suppressions_mac.txt
> b/tools/valgrind/memcheck/suppressions_mac.txt
> index
>
a94158706207b3c70a9f80afbd66591926b1f945..8757908fa51478cd1f7c7e9df1866bdedf1fad8a
> 100644
> --- a/tools/valgrind/memcheck/suppressions_mac.txt
> +++ b/tools/valgrind/memcheck/suppressions_mac.txt
> @@ -1098,4 +1098,23 @@
>
>
 fun:_ZN2v88internal9ParserApi15PartialPreParseENS0_6HandleINS0_6StringEEEPN7unibrow15CharacterStreamEPNS_9ExtensionE
>
>
 fun:_ZN2v88internal8Compiler7CompileENS0_6HandleINS0_6StringEEENS2_INS0_6ObjectEEEiiPNS_9ExtensionEPNS0_14ScriptDataImplES6_NS0_11NativesFlagE
>  }
> -
> +{
> +   bug_61816
> +   Memcheck:Leak
> +   fun:malloc_zone_malloc
> +   fun:_CFRuntimeCreateInstance
> +   fun:__CFDictionaryInit
> +   fun:utOpenActivateAllSelectedIMInDoc
> +   fun:MyActivateTSMDocument
> +   fun:ActivateTSMDocument
> +   fun:CallMyActivateTSMDocument
> +   fun:CFRunLoopRunSpecific
> +   fun:CFRunLoopRunInMode
> +   fun:RunCurrentEventLoopInMode
> +   fun:ReceiveNextEventCommon
> +   fun:BlockUntilNextEventMatchingListInMode
> +   fun:_DPSNextEvent
> +   fun:-[NSApplication nextEventMatchingMask:untilDate:inMode:dequeue:]
> +   fun:_ZN9CocoaTest8TearDownEv
> +
>
fun:_ZN7testingL35HandleExceptionsInMethodIfSupportedINS_4TestEvEET0_PT_MS3_FS2_vEPKc
> +}
>
>
>

Expand Messages | Collapse Messages