Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(51)

Issue 443021: Add test to expose bug 528... (Closed)

Created:
11 years ago by Søren Thygesen Gjesse
Modified:
9 years, 7 months ago
CC:
v8-dev
Visibility:
Public.

Description

Add test to expose bug 528 BUG=http://code.google.com/p/v8/issues/detail?id=528 TEST=cctest/test-api/Bug528 Committed: http://code.google.com/p/v8/source/detail?r=3372

Patch Set 1 #

Total comments: 8

Patch Set 2 : '' #

Unified diffs Side-by-side diffs Delta from patch set Stats (+120 lines, -0 lines) Patch
M src/objects-debug.cc View 1 chunk +16 lines, -0 lines 0 comments Download
M test/cctest/test-api.cc View 1 1 chunk +104 lines, -0 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Søren Thygesen Gjesse
11 years ago (2009-11-26 16:02:25 UTC) #1
Mads Ager (chromium)
LGTM http://codereview.chromium.org/443021/diff/1/2 File test/cctest/test-api.cc (right): http://codereview.chromium.org/443021/diff/1/2#newcode8530 test/cctest/test-api.cc:8530: // Context dendent context creates reference from the ...
11 years ago (2009-11-27 07:14:45 UTC) #2
Søren Thygesen Gjesse
11 years ago (2009-11-27 07:56:17 UTC) #3
http://codereview.chromium.org/443021/diff/1/2
File test/cctest/test-api.cc (right):

http://codereview.chromium.org/443021/diff/1/2#newcode8530
test/cctest/test-api.cc:8530: // Context dendent context creates reference from
the compilation cache to the
On 2009/11/27 07:14:45, Mads Ager wrote:
> Context-dependent context data?

Done.

http://codereview.chromium.org/443021/diff/1/2#newcode8542
test/cctest/test-api.cc:8542: //context.MakeWeak(&got_callback,
SetBooleanCallback);
On 2009/11/27 07:14:45, Mads Ager wrote:
> I guess this is not needed?  Please remove the callback as well in that case.

Done.

http://codereview.chromium.org/443021/diff/1/2#newcode8544
test/cctest/test-api.cc:8544: globals = true;
On 2009/11/27 07:14:45, Mads Ager wrote:
> Use break in the loops instead?

Done.

http://codereview.chromium.org/443021/diff/1/2#newcode8549
test/cctest/test-api.cc:8549: 
On 2009/11/27 07:14:45, Mads Ager wrote:
> You should probably check that there are no global objects at this time?

Done.

Powered by Google App Engine
This is Rietveld 408576698