Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(7424)

Unified Diff: chrome/chrome.gyp

Issue 443011: Refactor OS-dependent filename exclusion patterns (Closed)
Patch Set: cleanups Created 11 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« build/common.gypi ('K') | « build/common.gypi ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/chrome.gyp
diff --git a/chrome/chrome.gyp b/chrome/chrome.gyp
index b2ab98812962eff1589ba1edcaef9b72ad0b9b07..e3cc815cbd1825126c46279236b4036c398d64f8 100755
--- a/chrome/chrome.gyp
+++ b/chrome/chrome.gyp
@@ -190,36 +190,6 @@
}],
], # conditions
}, # variables
- 'target_defaults': {
- 'sources/': [
- ['exclude', '/(cocoa|gtk|win)/'],
- ['exclude', '_(cocoa|gtk|linux|mac|posix|skia|win|views|x)(_unittest)?(_mac)?\\.(cc|mm?)$'],
- ['exclude', '/(gtk|win|x11)_[^/]*\\.cc$'],
- ],
- 'conditions': [
- ['OS=="linux" or OS=="freebsd"', {'sources/': [
- ['include', '/gtk/'],
- ['include', '_(gtk|linux|posix|skia|x)(_unittest)?\\.cc$'],
- ['include', '/(gtk|x11)_[^/]*\\.cc$'],
- ]}],
- ['OS=="mac"', {'sources/': [
- ['include', '/cocoa/'],
- ['include', '_(cocoa|mac|posix)(_unittest)?(_mac)?\\.(cc|mm?)$'],
- ]}, { # else: OS != "mac"
- 'sources/': [
- ['exclude', '\\.mm?$'],
- ],
- }],
- ['OS=="win"', {'sources/': [
- ['include', '_(views|win)(_unittest)?\\.cc$'],
- ['include', '/win/'],
- ['include', '/(views|win)_[^/]*\\.cc$'],
- ]}],
- ['OS=="linux" and toolkit_views==1', {'sources/': [
- ['include', '_views\\.cc$'],
- ]}],
- ],
- },
'targets': [
{
# TODO(mark): It would be better if each static library that needed
« build/common.gypi ('K') | « build/common.gypi ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698