Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(722)

Issue 443009: Fix typo in recursion detection logic... (Closed)

Created:
11 years ago by jar (doing other things)
Modified:
9 years, 7 months ago
Reviewers:
Mike Belshe
CC:
chromium-reviews_googlegroups.com, pam+watch_chromium.org
Visibility:
Public.

Description

Fix typo in recursion detection logic When releasing the lock, I incorrectly set the thread owner for the lock to the current thread, rather than resetting it to zero. The result is that some number of stacks were not being recorded into the stack map (because the recursion blocking logic aborted the attempt to gather the lock). If I ever do a recursive acquisition (i.e., my logic is faulty), then an assertion will fire in the Acquire() for the lock. This in turn guarantees that when I Release() the lock, it was not a (windows allowed) recursive acquisition of the lock, and hence the thread owning the lock should indeed be zeroed. r=mbelshe Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=33140

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M tools/memory_watcher/call_stack.h View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 2 (0 generated)
jar (doing other things)
11 years ago (2009-11-25 21:55:28 UTC) #1
Mike Belshe
11 years ago (2009-11-25 22:19:15 UTC) #2
lgtm

Powered by Google App Engine
This is Rietveld 408576698