Issue 443002: Support context data in form of a string...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 443002: Support context data in form of a string... (Closed)

Created:
11 years ago by Søren Thygesen Gjesse

Modified:
9 years, 7 months ago

Reviewers:
pfeldman, yurys

CC:
chromium-reviews_googlegroups.com, darin (slow to review), pam+watch_chromium.org

Base URL:
http://src.chromium.org/svn/trunk/src/

Visibility:
Public.

Support context data in form of a string WbeKit bug 31873 (https://bugs.webkit.org/show_bug.cgi?id=31873) changes the context "data" from a JavaScript object to a string. This chakge should support both the string and the JavaScript object format. When the WebKit change has landed the support for a JavaScript will be removed. BUG=23058 TEST=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=33197

Created: 11 years ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+29 lines, -6 lines)			Patch
	M	webkit/glue/devtools/js/debugger_agent.js	View	1	2 chunks	+26 lines, -2 lines	0 comments	Download
	M	webkit/glue/devtools/js/devtools_host_stub.js	View		2 chunks	+3 lines, -4 lines	0 comments	Download

Total messages: 3 (0 generated)

Søren Thygesen Gjesse

This is a requirement for the change in https://bugs.webkit.org/show_bug.cgi?id=31873.

11 years ago (2009-11-25 16:25:11 UTC) #1

LGTM

On 2009/11/25 16:32:44, Søren Gjesse wrote:
>