Issue 4425001: Do not use the new message pump for TOUCH_UI yet.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 4425001: Do not use the new message pump for TOUCH_UI yet. (Closed)

Created:
10 years, 1 month ago by bryeung

Modified:
9 years, 7 months ago

Reviewers:
rjkroege, sadrul, Evan Martin

CC:
chromium-reviews, brettw-cc_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

Description

Do not use the new message pump for TOUCH_UI yet. It isn't quite ready. BUG=none TEST=build and run chrome, can type in the omnibox again Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=64975

Patch Set 1 #

Total comments: 1

Patch Set 2 : review comments #

Created: 10 years, 1 month ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+2 lines, -1 line)			Patch
	M	base/message_loop.cc	View	1	1 chunk	+2 lines, -1 line	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

rjkroege

10 years, 1 month ago (2010-11-03 21:41:32 UTC) #3

LGTM

http://codereview.chromium.org/4425001/diff/1/2
File base/message_loop.cc (right):

http://codereview.chromium.org/4425001/diff/1/2#newcode141
base/message_loop.cc:141: #define MESSAGE_PUMP_UI new base::MessagePumpForUI()
please add a TODO(sadrul) to re-enable when ready.

Expand Messages | Collapse Messages