Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(30)

Issue 4421001: Revert 64828 - "Revert 64493 - These are files need to be added to benchmarks extension." (Closed)

Created:
10 years, 1 month ago by Tessa MacDuff
Modified:
9 years, 7 months ago
CC:
chromium-reviews, Aaron Boodman, Erik does not do reviews, pam+watch_chromium.org
Visibility:
Public.

Description

Revert 64828 - "Revert 64493 - These are files need to be added to benchmarks extension." This reverts commit fbf3155bc7b82cbf56c9e6bdbd806a81daf2f2ce. Also update docs. BUG=61650 TEST=Successfully ran build.py Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=64979

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+586 lines, -0 lines) Patch
A chrome/common/extensions/docs/examples/extensions/benchmark/jquery/jquery.flot.min.js View 1 chunk +1 line, -0 lines 0 comments Download
A chrome/common/extensions/docs/examples/extensions/benchmark/util/sorttable.js View 1 chunk +489 lines, -0 lines 0 comments Download
A chrome/common/extensions/docs/examples/extensions/benchmark/util/table2CSV.js View 1 chunk +90 lines, -0 lines 0 comments Download
M chrome/common/extensions/docs/samples.html View 2 chunks +6 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
Tessa MacDuff
10 years, 1 month ago (2010-11-03 21:18:52 UTC) #1
lzheng
LGTM. Do I need to update samples.html everytime there is a new file added? Thanks! ...
10 years, 1 month ago (2010-11-03 21:26:13 UTC) #2
Tessa MacDuff
samples.html was updated automatically when I ran build.py. I think anytime you change something in ...
10 years, 1 month ago (2010-11-03 21:33:51 UTC) #3
tessamac
The preseubmit claims these js files have "a bad license header". I'm guessing this is ...
10 years, 1 month ago (2010-11-03 21:40:54 UTC) #4
lzheng1
10 years, 1 month ago (2010-11-03 22:10:20 UTC) #5
I believe it is because the license headers are not in the format we want
for chromium, but they are fine with what they have now.

Lei

On Wed, Nov 3, 2010 at 2:40 PM, <tessamac@google.com> wrote:

> The preseubmit claims these js files have "a bad license header".  I'm
> guessing
> this is expected, but I just want to double check.
>
>
> On 2010/11/03 21:33:51, Tessa MacDuff wrote:
>
>> samples.html was updated automatically when I ran build.py.
>>
>
>  I think anytime you change something in the extensions/docs/ directory
>> it's
>> a good idea to run build.py (usually with --nozip) to make sure the docs
>> get
>> updated if needbe.
>>
>
>   From the
>>
>
> README.txt<
>
http://src.chromium.org/viewvc/chrome/trunk/src/chrome/common/extensions/docs...
> >
>
>  :
>>
>
>  Building
>>
>
>
>  > Changes to the extension docs must be checked into source control. Any
>> > changes to any input sources require the docs to be regenerated.
>>
>
>
>  > To build the extension docs, run the build.py script in the ./build
>> > directory. This will regenerate the docs and report which, if any, files
>> > have changed and need to be included in the changelist that changed the
>> > dependent files.
>>
>
>
>  > Note that the build.py script depends on test_shell to run, so you must
>> be
>> > able to build test_shell to build extension_docs. The build.py script
>> will
>> > look in typical locations for the test_shell executable, but you may set
>> the
>> > path to test_shell explicitly with --test-shell-path.
>>
>
>
>
>  On Wed, Nov 3, 2010 at 14:26, <mailto:lzheng@chromium.org> wrote:
>>
>
>  > LGTM.
>> >
>> > Do I need to update samples.html everytime there is a new file added?
>> > Thanks!
>> >
>> >
>> > On 2010/11/03 21:18:52, Tessa MacDuff wrote:
>> >
>> >
>> >
>> >
>> > http://codereview.chromium.org/4421001/show
>> >
>>
>
>
>
>
> http://codereview.chromium.org/4421001/show
>

Powered by Google App Engine
This is Rietveld 408576698