Issue 441017: Make heap serialization nondestructive.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 441017: Make heap serialization nondestructive. (Closed)

Created:
11 years ago by Erik Corry

Modified:
9 years, 7 months ago

Reviewers:
Kasper Lund

CC:
v8-dev

Base URL:
http://v8.googlecode.com/svn/branches/bleeding_edge/

Visibility:
Public.

Description

Make heap serialization nondestructive. Committed: http://code.google.com/p/v8/source/detail?r=3360

Patch Set 1 #

Total comments: 1

Created: 11 years ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+110 lines, -44 lines)			Patch
M	src/objects.h	View	1 chunk	+0 lines, -10 lines	0 comments	Download
M	src/objects-inl.h	View	1 chunk	+0 lines, -19 lines	0 comments	Download
M	src/serialize.cc	View	5 chunks	+74 lines, -14 lines	1 comment	Download
M	test/cctest/test-serialize.cc	View	3 chunks	+36 lines, -1 line	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Kasper Lund

11 years ago (2009-11-25 12:52:03 UTC) #2

LGTM.

http://codereview.chromium.org/441017/diff/1/4
File src/serialize.cc (right):

http://codereview.chromium.org/441017/diff/1/4#newcode96
src/serialize.cc:96: static void MapExists() {
EnsureMapExists?

Expand Messages | Collapse Messages