Many changes to DictionaryValues:...

chrome/common/pref_service_unittest.cc

-// Copyright (c) 2006-2008 The Chromium Authors. All rights reserved.
+// Copyright (c) 2009 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "app/test/data/resource.h"
 #include "base/file_util.h"
 #include "base/message_loop.h"
 #include "base/path_service.h"
 #include "chrome/browser/chrome_thread.h"
 #include "chrome/common/chrome_paths.h"
 #include "chrome/common/json_value_serializer.h"
@@ skipping 98 matching lines @@
   std::wstring homepage(L"http://www.example.com");
 
   EXPECT_EQ(cnn, prefs.GetString(prefs::kHomePage));
 
   const wchar_t kSomeDirectory[] = L"some_directory";
   FilePath some_path(FILE_PATH_LITERAL("/usr/sbin/"));
   prefs.RegisterFilePathPref(kSomeDirectory, FilePath());
 
   // Now test that the transient value overrides the persistent value,
   // without actually altering the persistent store.
-  EXPECT_TRUE(prefs.transient()->SetString(prefs::kHomePage, microsoft));
+  prefs.transient()->SetString(prefs::kHomePage, microsoft);
   EXPECT_TRUE(prefs.transient()->GetString(prefs::kHomePage, &homepage));
   EXPECT_EQ(microsoft, homepage);
 
   EXPECT_EQ(microsoft, prefs.GetString(prefs::kHomePage));
 
   // Test reading some other data types from sub-dictionaries, and
   // writing to the persistent store.
   EXPECT_TRUE(prefs.GetBoolean(kNewWindowsInTabs));
   prefs.SetBoolean(kNewWindowsInTabs, false);
   EXPECT_FALSE(prefs.GetBoolean(kNewWindowsInTabs));
@@ skipping 271 matching lines @@
 
   // Register the path. This doesn't set a value, so the path still shouldn't
   // exist.
   prefs.RegisterStringPref(path, std::wstring());
   EXPECT_FALSE(prefs.HasPrefPath(path));
 
   // Set a value and make sure we have a path.
   prefs.SetString(path, L"blah");
   EXPECT_TRUE(prefs.HasPrefPath(path));
 }