Many changes to DictionaryValues:...

chrome/browser/bookmarks/bookmark_codec_unittest.cc

-// Copyright (c) 2006-2009 The Chromium Authors. All rights reserved.
+// Copyright (c) 2009 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "base/scoped_ptr.h"
 #include "base/string_util.h"
 #include "base/values.h"
 #include "chrome/browser/bookmarks/bookmark_codec.h"
 #include "chrome/browser/bookmarks/bookmark_model.h"
 #include "chrome/browser/bookmarks/bookmark_model_test_utils.h"
 #include "chrome/browser/bookmarks/bookmark_utils.h"
@@ skipping 183 matching lines @@
   std::string enc_checksum;
   scoped_ptr<Value> value(EncodeHelper(model_to_encode.get(), &enc_checksum));
 
   EXPECT_TRUE(value.get() != NULL);
 
   // Change something in the encoded value before decoding it.
   DictionaryValue* child1_value;
   GetBookmarksBarChildValue(value.get(), 0, &child1_value);
   std::wstring title;
   ASSERT_TRUE(child1_value->GetString(BookmarkCodec::kNameKey, &title));
-  ASSERT_TRUE(child1_value->SetString(BookmarkCodec::kNameKey, title + L"1"));
+  child1_value->SetString(BookmarkCodec::kNameKey, title + L"1");
 
   std::string dec_checksum;
   scoped_ptr<BookmarkModel> decoded_model1(DecodeHelper(
       *value.get(), enc_checksum, &dec_checksum, true));
 
   // Undo the change and make sure the checksum is same as original.
-  ASSERT_TRUE(child1_value->SetString(BookmarkCodec::kNameKey, title));
+  child1_value->SetString(BookmarkCodec::kNameKey, title);
   scoped_ptr<BookmarkModel> decoded_model2(DecodeHelper(
       *value.get(), enc_checksum, &dec_checksum, false));
 }
 
 TEST_F(BookmarkCodecTest, ChecksumManualEditIDsTest) {
   scoped_ptr<BookmarkModel> model_to_encode(CreateTestModel3());
 
   // The test depends on existence of multiple children under bookmark bar, so
   // make sure that's the case.
   int bb_child_count = model_to_encode->GetBookmarkBarNode()->GetChildCount();
   ASSERT_GT(bb_child_count, 1);
 
   std::string enc_checksum;
   scoped_ptr<Value> value(EncodeHelper(model_to_encode.get(), &enc_checksum));
 
   EXPECT_TRUE(value.get() != NULL);
 
   // Change IDs for all children of bookmark bar to be 1.
   DictionaryValue* child_value;
   for (int i = 0; i < bb_child_count; ++i) {
     GetBookmarksBarChildValue(value.get(), i, &child_value);
     std::string id;
     ASSERT_TRUE(child_value->GetString(BookmarkCodec::kIdKey, &id));
-    ASSERT_TRUE(child_value->SetString(BookmarkCodec::kIdKey, "1"));
+    child_value->SetString(BookmarkCodec::kIdKey, "1");
   }
 
   std::string dec_checksum;
   scoped_ptr<BookmarkModel> decoded_model(DecodeHelper(
       *value.get(), enc_checksum, &dec_checksum, true));
 
   ExpectIDsUnique(decoded_model.get());
 
   // add a few extra nodes to bookmark model and make sure IDs are still uniuqe.
   const BookmarkNode* bb_node = decoded_model->GetBookmarkBarNode();
@@ skipping 27 matching lines @@
   BookmarkCodec encoder2;
   scoped_ptr<Value> model_value2(encoder2.Encode(&decoded_model));
 
   BookmarkModel decoded_model2(NULL);
   BookmarkCodec decoder2;
   ASSERT_TRUE(Decode(&decoder2, &decoded_model2, *model_value2.get()));
   BookmarkModelTestUtils::AssertModelsEqual(&decoded_model,
                                             &decoded_model2,
                                             true);
 }