net: Make Snap Start check cert verification and add metrics

net/socket/ssl_host_info.cc

 // Copyright (c) 2010 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "net/socket/ssl_host_info.h"
 
+#include "base/metrics/histogram.h"
 #include "base/string_piece.h"
 #include "net/base/cert_verifier.h"
 #include "net/base/ssl_config_service.h"
 #include "net/base/x509_certificate.h"
 #include "net/socket/ssl_client_socket.h"
 #include "net/socket/ssl_host_info.pb.h"
 
 namespace net {
 
 SSLHostInfo::State::State()
@@ skipping 86 matching lines @@
       der_certs[i] = state->certs[i];
     cert_ = X509Certificate::CreateFromDERCertChain(der_certs);
     if (cert_.get()) {
       int flags = 0;
       if (verify_ev_cert_)
         flags |= X509Certificate::VERIFY_EV_CERT;
       if (rev_checking_enabled_)
         flags |= X509Certificate::VERIFY_REV_CHECKING_ENABLED;
       verifier_.reset(new CertVerifier);
       VLOG(1) << "Kicking off verification for " << hostname_;
+      verification_start_time_ = base::TimeTicks::Now();
       if (verifier_->Verify(cert_.get(), hostname_, flags,
                             &cert_verify_result_, callback_) == OK) {
         VerifyCallback(OK);
       }
     } else {
       cert_parsing_failed_ = true;
       DCHECK(!cert_verification_callback_);
     }
   }
 
@@ skipping 25 matching lines @@
 int SSLHostInfo::WaitForCertVerification(CompletionCallback* callback) {
   if (cert_verification_complete_)
     return cert_verification_result_;
   DCHECK(!cert_parsing_failed_);
   DCHECK(!cert_verification_callback_);
   DCHECK(!state_.certs.empty());
   cert_verification_callback_ = callback;
   return ERR_IO_PENDING;
 }
 
 void SSLHostInfo::VerifyCallback(int rv) {

[Mike Belshe, 2010/11/03 19:55:11]

nit:  add DCHECK(!verification_start_time().is_null())

+  base::TimeTicks now = base::TimeTicks::Now();
+  const base::TimeDelta duration = now - verification_start_time();
+  UMA_HISTOGRAM_TIMES("Net.SSLHostInfoVerificationTimeMs", duration);
+  VLOG(1) << "Verification took " << duration.InMilliseconds() << "ms";
   cert_verification_complete_ = true;
   cert_verification_result_ = rv;
   if (cert_verification_callback_) {
     CompletionCallback* callback = cert_verification_callback_;
     cert_verification_callback_ = NULL;
     callback->Run(rv);
   }
 }
 
 SSLHostInfoFactory::~SSLHostInfoFactory() {}
 
 }  // namespace net