Issue 4408001: net: Make Snap Start check cert verification and add metrics

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 4408001: net: Make Snap Start check cert verification and add metrics (Closed)

Created:
10 years, 1 month ago by agl

Modified:
9 years, 7 months ago

Reviewers:
Mike Belshe

CC:
chromium-reviews, cbentzel+watch_chromium.org, darin-cc_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

Description

net: Make Snap Start check cert verification and add metrics This CL causes Snap Start to only trigger if the certificate verification has completed by the time we are ready to send out the handshake message. It also adds a couple of NetLog entries and histograms around the Snap Start code. BUG=none TEST=none

Patch Set 1 #

Total comments: 1

Created: 10 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+51 lines, -13 lines)			Patch
M	net/base/net_log_event_type_list.h	View	1 chunk	+11 lines, -0 lines	0 comments	Download
M	net/socket/ssl_client_socket_nss.cc	View	5 chunks	+28 lines, -13 lines	0 comments	Download
M	net/socket/ssl_host_info.h	View	3 chunks	+6 lines, -0 lines	0 comments	Download
M	net/socket/ssl_host_info.cc	View	3 chunks	+6 lines, -0 lines	1 comment	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Mike Belshe

LGTM- thanks for adding the metrics. I guess you didn't want to add the short ...

10 years, 1 month ago (2010-11-03 19:55:11 UTC) #2

agl

10 years, 1 month ago (2010-11-03 19:58:15 UTC) #3

On Wed, Nov 3, 2010 at 3:55 PM,  <mbelshe@chromium.org> wrote:
> I guess you didn't want to add the short delay before proceeding with
> snapstart yet?  Seems ok.  We can collect data first.

Yea, wanted data first. It would be nice not to need it.


AGL

Expand Messages | Collapse Messages