Issue 4403001: VM: Add board, image_path and base_ssh_port options.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 4403001: VM: Add board, image_path and base_ssh_port options. (Closed)

Created:
10 years, 1 month ago by petkov

Modified:
9 years, 7 months ago

Reviewers:
sosa

CC:
chromium-os-reviews_chromium.org, Mandeep Singh Baines, anush, sosa

Base URL:
ssh://git@gitrw.chromium.org:9222/crosutils.git@master

Visibility:
Public.

Description

VM: Add board, image_path and base_ssh_port options. BUG=8585 TEST=manual, tried different options Change-Id: I66be3930cefdf4ea382e1ed8aba54a66f4bfb36e Committed: http://chrome-svn/viewvc/chromeos?view=rev&revision=4050814

Patch Set 1 #

Total comments: 2

Patch Set 2 : review comment #

Created: 10 years, 1 month ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+37 lines, -6 lines)			Patch
	M	bin/cros_run_parallel_vm_tests.py	View	1	4 chunks	+37 lines, -6 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

sosa

LGTM w/ nit http://codereview.chromium.org/4403001/diff/1/2 File bin/cros_run_parallel_vm_tests.py (right): http://codereview.chromium.org/4403001/diff/1/2#newcode62 bin/cros_run_parallel_vm_tests.py:62: ssh_port = _DEFAULT_BASE_SSH_PORT Why not just ...

10 years, 1 month ago (2010-11-03 19:29:13 UTC) #3

petkov

10 years, 1 month ago (2010-11-03 19:33:26 UTC) #4

Pushing...

http://codereview.chromium.org/4403001/diff/1/2
File bin/cros_run_parallel_vm_tests.py (right):

http://codereview.chromium.org/4403001/diff/1/2#newcode62
bin/cros_run_parallel_vm_tests.py:62: ssh_port = _DEFAULT_BASE_SSH_PORT
On 2010/11/03 19:29:13, sosa wrote:
> Why not just set this default in _init_(_base_ssh_port=_DEFAULT_blah

Good point. Done.

Expand Messages | Collapse Messages